feat: support TypeScript syntax in no-invalid-this rule
#19532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please take a look at the test failures. |
19 tasks
snitin315
reviewed
Mar 21, 2025
snitin315
added
the
accepted
snitin315
reviewed
Mar 22, 2025
snitin315
previously approved these changes
Mar 22, 2025
docs/src/rules/no-invalid-this.md
Outdated
| ## When Not To Use It | ||
|
|
||
| If you don't want to be notified about usage of `this` keyword outside of classes or class-like objects, you can safely disable this rule. | ||
|
|
||
| The TypeScript compiler already checks for the issues addressed by this ESLint rule. Therefore, enabling this rule in new TypeScript projects is generally unnecessary. You should only enable it if you prefer ESLint's error messages over the TypeScript compiler's or if you're using it to lint JavaScript code. |
There was a problem hiding this comment.
We already have meta fields for this purpose. For example:
eslint/docs/src/rules/no-import-assign.md
Lines 4 to 5 in 6be36c9
There was a problem hiding this comment.
Actually, this rule's docs already have these fields specified, so this paragraph seems like an unnecessary duplicate.
https://eslint.org/docs/latest/rules/no-invalid-this#handled_by_typescript
lib/rules/no-invalid-this.js
Outdated
Comment on lines
145
to
155
| AccessorProperty(node) { | ||
| stack.push({ | ||
| init: true, | ||
| node, | ||
| valid: true, | ||
| }); | ||
| }, | ||
|
|
||
| "AccessorProperty:exit"() { | ||
| stack.pop(); | ||
| }, |
There was a problem hiding this comment.
I think this would be a false negative:
function foo() {
class C {
accessor [this.a] = foo;
}
}
mdjermanovic
reviewed
Apr 4, 2025
mdjermanovic
reviewed
Apr 5, 2025
mdjermanovic
reviewed
Apr 5, 2025
mdjermanovic
reviewed
Apr 5, 2025
mdjermanovic
approved these changes
Apr 6, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added support of TypeScript syntax in
no-invalid-thisrule. such asrule will not report
thiswhen it's type is checked in functions.thiswill be allowed in Accessor Property of class field initializers.Is there anything you'd like reviewers to focus on?
Refs #19173.