Skip to content

Remove otel semcov package from core dependencies #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Remove otel semcov package from core dependencies #6775

merged 1 commit into from
Jul 9, 2025

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jul 9, 2025

Resolves #6768

@ekzhu ekzhu mentioned this pull request Jul 9, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.45%. Comparing base (203323f) to head (fc58fb9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6775      +/-   ##
==========================================
+ Coverage   80.44%   80.45%   +0.01%     
==========================================
  Files         237      237              
  Lines       17864    17880      +16     
==========================================
+ Hits        14370    14386      +16     
  Misses       3494     3494
Flag Coverage Δ
unittests 80.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yoichiro0abe
yoichiro0abe approved these changes Jul 9, 2025
View reviewed changes
Copy link

@yoichiro0abe yoichiro0abe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your prompt response. The changes look good to me. Please proceed with the merge.

@ekzhu ekzhu merged commit f881d8a into main Jul 9, 2025
69 checks passed
@ekzhu ekzhu deleted the ekzhu-otel-semantic-conv branch July 9, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoichiro0abe yoichiro0abe yoichiro0abe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetry is required even when tracing is disabled — should be optional
2 participants
@ekzhu @yoichiro0abe