Add sidenote examples, related posts and giscus to distill posts #3103
Conversation
Fix JQuery loading for footnotes and citations formatting on distill posts Fix parity between al-folio post and distill post - Add related posts to distill post - Fix formatting for giscus widgets on distill post
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
assets/js/distillpub/template.v2.js
Outdated
| @@ -3170,7 +3170,7 @@ | |||
| var def = {}; | |||
| def[tagName] = { | |||
| pattern: RegExp( | |||
| /(<__[\s\S]*?>)(?:<!\[CDATA\[[\s\S]*?\]\]>\s*|[\s\S])*?(?=<\/__>)/.source.replace(/__/g, function () { | |||
| /(<__[^<]*?>)(?:<!\[CDATA\[[^<]*?\]\]>\s*|[^<])*?(?=<\/__>)/.source.replace(/__/g, function () { | |||
Check failure
Code scanning / CodeQL
Inefficient regular expression
assets/js/distillpub/template.v2.js
Outdated
| @@ -3170,7 +3170,7 @@ | |||
| var def = {}; | |||
| def[tagName] = { | |||
| pattern: RegExp( | |||
| /(<__[\s\S]*?>)(?:<!\[CDATA\[[\s\S]*?\]\]>\s*|[\s\S])*?(?=<\/__>)/.source.replace(/__/g, function () { | |||
| /(<__[^<]*?>)(?:<!\[CDATA\[[^<]*?\]\]>\s*|[^<])*?(?=<\/__>)/.source.replace(/__/g, function () { | |||
Check failure
Code scanning / CodeQL
Inefficient regular expression
There was a problem hiding this comment.
Pull Request Overview
This pull request adds stylistic improvements and examples for distill-style blog posts. Key changes include:
- Adding an overrides.js script to update footnote and citation styles via shadow DOM manipulation.
- Introducing a new “Sidenotes” section in a sample blog post demonstrating two methods (using the tag and the l-gutter class) for displaying sidenotes.
- Updating content to showcase equations in sidenotes.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/js/distillpub/overrides.js | Introduces JavaScript to override styles for footnotes and citations in alignment with the global theme. |
| _posts/2018-12-22-distill.md | Adds a Sidenotes section with HTML examples to illustrate alternative styling options. |
Files not reviewed (4)
- _includes/distill_scripts.liquid: Language not supported
- _includes/giscus.liquid: Language not supported
- _includes/related_posts.liquid: Language not supported
- _layouts/distill.liquid: Language not supported
|
Just saw that there was the possibility to ask copilot for review and tried, but you can ignore it. I was just testing. I am kind with my hands full now, but I will try to review this on the weekend. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Is this still useful @george-gca? |
|
Sorry, I've been under a really tight constraint, so I haven't had the time to properly review PRs with more code changes. I will try to do this weekend without failure. |
This PR adds a few stylistic improvements to the distill-style blog posts:
overrides.jsto match footnotes and citation styles with global theme stylinga-distill-style-blog-post-You-R-Name.mp4