Skip to content

test(ci): use GitHub Actions for Ubuntu CI #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

test(ci): use GitHub Actions for Ubuntu CI #719

wants to merge 4 commits into from

Conversation

bnb
Copy link

@bnb bnb commented Sep 23, 2020

Uses GitHub Actions for Ubuntu CI.

@bnb
Copy link
Author

bnb commented Sep 23, 2020

So this has two failing tests - they actually look like they're doing the right thing but are starting with the wrong value (expected: 800 / got: 650 and expected: 780 / got: 630).

@bnb
Copy link
Author

bnb commented Sep 24, 2020

The Windows runner seems to be entirely stuck - running for 1:30 at this point and I saw a tiny error before it got to this state 😬

@bnb
Copy link
Author

bnb commented Sep 24, 2020

This Windows failure seems to be unrelated to my changes here.

  1) window commands
       webContents.selectAll()
         selects all the text on the page:
     AssertionError: expected '' to include 'Hello'
      at Context.<anonymous> (test\commands-test.js:170:23)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

It does seem that there are also two UnhandledPromiseRejectionWarnings in the logs in Windows:

This is potentially related to the test I've changed:

example application launch
(node:1028) UnhandledPromiseRejectionWarning: RequestError: read ECONNRESET
    at ClientRequest.<anonymous> (D:\a\spectron\spectron\node_modules\webdriver\node_modules\got\dist\source\core\index.js:957:25)
    at Object.onceWrapper (events.js:422:26)
    at ClientRequest.emit (events.js:327:22)
    at ClientRequest.EventEmitter.emit (domain.js:483:12)
    at ClientRequest.origin.emit (D:\a\spectron\spectron\node_modules\webdriver\node_modules\@szmarczak\http-timer\dist\source\index.js:39:20)
    at Socket.socketErrorListener (_http_client.js:426:9)
    at Socket.emit (events.js:315:20)
    at Socket.EventEmitter.emit (domain.js:483:12)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
    at TCP.onStreamRead (internal/stream_base_commons.js:205:27)
(node:1028) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 4)
(node:1028) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:1028) UnhandledPromiseRejectionWarning: RequestError: read ECONNRESET
    at ClientRequest.<anonymous> (D:\a\spectron\spectron\node_modules\webdriver\node_modules\got\dist\source\core\index.js:957:25)
    at Object.onceWrapper (events.js:422:26)
    at ClientRequest.emit (events.js:327:22)
    at ClientRequest.EventEmitter.emit (domain.js:483:12)
    at ClientRequest.origin.emit (D:\a\spectron\spectron\node_modules\webdriver\node_modules\@szmarczak\http-timer\dist\source\index.js:39:20)
    at Socket.socketErrorListener (_http_client.js:426:9)
    at Socket.emit (events.js:315:20)
    at Socket.EventEmitter.emit (domain.js:483:12)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
    at TCP.onStreamRead (internal/stream_base_commons.js:205:27)
(node:1028) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 5)

This failure seems unrelated to changes in this PR

  requireName option to Application
(node:1028) UnhandledPromiseRejectionWarning: RequestError: read ECONNRESET
    at ClientRequest.<anonymous> (D:\a\spectron\spectron\node_modules\webdriver\node_modules\got\dist\source\core\index.js:957:25)
    at Object.onceWrapper (events.js:422:26)
    at ClientRequest.emit (events.js:327:22)
    at ClientRequest.EventEmitter.emit (domain.js:483:12)
    at ClientRequest.origin.emit (D:\a\spectron\spectron\node_modules\webdriver\node_modules\@szmarczak\http-timer\dist\source\index.js:39:20)
    at Socket.socketErrorListener (_http_client.js:426:9)
    at Socket.emit (events.js:315:20)
    at Socket.EventEmitter.emit (domain.js:483:12)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
    at TCP.onStreamRead (internal/stream_base_commons.js:205:27)
(node:1028) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 6)

@AviVahl AviVahl mentioned this pull request Nov 25, 2020
Merged
jkleinsc pushed a commit that referenced this pull request Nov 30, 2020
@AviVahl
test(ci): use github actions Linux container (#782)
d515796 
- with the electron@11 fixes now in `master`, this might actually pass.
- dropped Travis and updated README's badge.
- adjusted xvfb to 1024x768 by default.

closes #719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bnb