Skip to content

plugins.atresplayer: fix player API URL #5477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

pablohoffman
Copy link
Contributor

@pablohoffman pablohoffman commented Aug 3, 2023

Fixes #5131

Fix atresplayer plugin, which broke recently (presumably due to site changes)

@pablohoffman pablohoffman force-pushed the fix-atresplayer-plugin branch from cfd02f2 to 29d4af4 Compare August 3, 2023 12:57
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pablohoffman

@bastimeyer bastimeyer changed the title Fix atresmedia plugin plugins.atresmedia: fix player API URL Aug 3, 2023
@bastimeyer bastimeyer added plugin issue A Plugin does not work correctly restriction: geo blocked labels Aug 3, 2023
@pablohoffman
Copy link
Contributor Author

Thanks for the feedback @bastimeyer, I've sent a new commit to address it.

@bastimeyer
Copy link
Member

Could you please give the VODs a quick test?

That one VOD URL defined in the plugin test file has expired, but I'm not sure if your changes will work with any VODs.

$ ./script/test-plugin-urls.py atresplayer
:: Finding streams for URL: http://www.atresplayer.com/directos/antena3/
:::: Player API error: required_paid - Required paid
!! No streams found
:: Finding streams for URL: http://www.atresplayer.com/directos/lasexta/
:::: Player API error: required_paid - Required paid
!! No streams found
:: Finding streams for URL: https://www.atresplayer.com/directos/antena3/
:::: Player API error: required_paid - Required paid
!! No streams found
:: Finding streams for URL: https://www.atresplayer.com/flooxer/programas/unas/temporada-1/dario-eme-hache-sindy-takanashi-entrevista_123/
!! Error while fetching streams

@pablohoffman
Copy link
Contributor Author

@bastimeyer Atresplayer became a streaming platform and doesn't host VODs anymore, only live streams and shows/movies (do those count as VODs?) although I'm not sure if any of them are free.

Atresmedia (the company behind Atresplayer) does have other websites (lasexta.com, antena3.com) that host VODs but those would require separate handling, and I don't have time to add support for those now.

@bastimeyer
Copy link
Member

Then the pluginmatcher URL should get updated accordingly and the VOD removed from the test file. The plugin's metadata already states that it only supports live streams.

@bastimeyer bastimeyer changed the title plugins.atresmedia: fix player API URL plugins.atresplayer: fix player API URL Aug 5, 2023
@bastimeyer bastimeyer force-pushed the fix-atresplayer-plugin branch from e14cdd0 to f1d9770 Compare August 5, 2023 15:57
@bastimeyer
Copy link
Member

I force-pushed onto your PR branch with the necessary changes squashed into a proper single commit.

Please force-fetch locally and check if the channels listed here do indeed work (they are all geo-blocked and unlisted for me):
#5131 (comment)

Once validated, we can merge this.

@Jeffade1
Copy link

Jeffade1 commented Aug 6, 2023

@bastimeyer Passing there I did a quick check for you.

  • The usual important channels are working fine with the new plugin.
  • The fast channels in the list you pointed are showing:

error: Unable to validate response text: ValidationError(GetItemSchema):
Item 0 was not found in object []

Co-Authored-By: bastimeyer <mail@bastimeyer.de>
@bastimeyer bastimeyer force-pushed the fix-atresplayer-plugin branch from f1d9770 to ad62fb5 Compare August 6, 2023 22:15
@bastimeyer
Copy link
Member

Thanks, @Jeffade1
I fixed the validation error, but since this new plugin version is limited to the data returned by
https://api.atresplayer.com/client/v1/info/channels
the other channels will require a different solution.

@bastimeyer
Copy link
Member

I'm going to merge this now. If anyone wants to add support for the other channels, please open a new pull request. Thanks.

@bastimeyer bastimeyer merged commit 1124b52 into streamlink:master Aug 6, 2023
@pablohoffman
Copy link
Contributor Author

Thanks for the help and merge @bastimeyer @Jeffade1, I've been away from my desk for the last few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly restriction: geo blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins.atresplayer: no playable streams found
3 participants