-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.atresplayer: fix player API URL #5477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins.atresplayer: fix player API URL #5477
Conversation
cfd02f2
to
29d4af4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pablohoffman
Thanks for the feedback @bastimeyer, I've sent a new commit to address it. |
Could you please give the VODs a quick test? That one VOD URL defined in the plugin test file has expired, but I'm not sure if your changes will work with any VODs.
|
@bastimeyer Atresplayer became a streaming platform and doesn't host VODs anymore, only live streams and shows/movies (do those count as VODs?) although I'm not sure if any of them are free. Atresmedia (the company behind Atresplayer) does have other websites (lasexta.com, antena3.com) that host VODs but those would require separate handling, and I don't have time to add support for those now. |
Then the pluginmatcher URL should get updated accordingly and the VOD removed from the test file. The plugin's metadata already states that it only supports live streams. |
e14cdd0
to
f1d9770
Compare
I force-pushed onto your PR branch with the necessary changes squashed into a proper single commit. Please force-fetch locally and check if the channels listed here do indeed work (they are all geo-blocked and unlisted for me): Once validated, we can merge this. |
@bastimeyer Passing there I did a quick check for you.
error: Unable to validate response text: ValidationError(GetItemSchema): |
Co-Authored-By: bastimeyer <mail@bastimeyer.de>
f1d9770
to
ad62fb5
Compare
Thanks, @Jeffade1 |
I'm going to merge this now. If anyone wants to add support for the other channels, please open a new pull request. Thanks. |
Thanks for the help and merge @bastimeyer @Jeffade1, I've been away from my desk for the last few days. |
Fixes #5131
Fix atresplayer plugin, which broke recently (presumably due to site changes)