fix(DayRangePicker3): Fixed being able to get out of bounds in non contiguous mode #7277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(DayRangePicker3): Fixed being able to get out of boundsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
FormatBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
reviewed
Feb 26, 2025
| minDate: Date | undefined, | ||
| maxDate: Date | undefined, | ||
| ): [left: MonthAndYear, right: MonthAndYear] { | ||
| let minView = MonthAndYear.fromDate(minDate ?? null); |
There was a problem hiding this comment.
lint: These variables, minView and maxView can be const.
Fix lintBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
approved these changes
Feb 26, 2025
ggdouglas
pushed a commit
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7267
Changes proposed in this pull request:
Fixed an issue that would allow users to get out of bounds by moving to an invalid month in a different year and then changing to that year. For example, if the max date is March 2024, you can switch to May 2023 and then change the year to 2024 and result in a broken state. This works in both directions for min and max dates.
Some minimal repros include: