plugins.afreeca: update '_get_channel_info' with 'bno', plugin cleanup #3408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
back-to
added
plugin issue
bastimeyer
reviewed
Dec 13, 2020
| _re_bno = re.compile(r"var nBroadNo = (?P<bno>\d+);") | ||
| _re_url = re.compile(r"https?://play\.afreecatv\.com/(?P<username>\w+)(?:/(?P<bno>:\d+))?") | ||
|
|
||
| CHANNEL_API_URL = "http://live.afreecatv.com/afreeca/player_live_api.php" |
There was a problem hiding this comment.
Not sure if it's worth it, but the API URL could be changed to https and https added to _schema_stream down below. What's required for this to work is disabling the TLS validation via self.session.set_option("http-ssl-verify", False).
There was a problem hiding this comment.
there website uses http in the web browser,
adding https here with http-ssl-verify", False is currently unnecessary
back-to
added a commit
to back-to/streamlink
that referenced
this pull request
Dec 13, 2020
It has some downsides such as `--hls-timeout`, Plugin specified FilteredHLSStream should be used instead. streamlink#3187 --- Afreeca Plugin as an Example streamlink#3408 --- Revert streamlink#1432
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 14, 2020
…n cleanup (streamlink#3408) - use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 14, 2020
…n cleanup (streamlink#3408) - use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 17, 2020
…n cleanup (streamlink#3408) - use broadcast number for _get_channel_info - use FilteredHLSStream instead of --hls-segment-ignore-names - save cookies for a user session - add new option --afreeca-purge-credentials - general plugin cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3407