Skip to content

Commit b982d71

Browse files
insideguiinsidegui
committed
Fix most warnings related to modern Swift/SDK
1 parent 9095fa9 commit b982d71

13 files changed

+22
-19
lines changed

‎Packages/ConfCore/ConfCore/Storage.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ public final class Storage: Logging, Signposting {
155155
// add instances and sessions to events
156156
let instancesToEvents = Self.signposter.beginInterval("store content result", id: Self.signposter.makeSignpostID(), "add instances and sessions to events")
157157
backgroundRealm.objects(Event.self).forEach { event in
158-
let instances = backgroundRealm.objects(SessionInstance.self).filter("eventIdentifier == %@", event.identifier)
159158
let sessions = backgroundRealm.objects(Session.self).filter("eventIdentifier == %@", event.identifier)
160159

161160
event.sessionInstances.removeAll()

‎WWDC.xcodeproj/project.pbxproj

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1353,7 +1353,7 @@
13531353
attributes = {
13541354
BuildIndependentTargetsInParallel = YES;
13551355
LastSwiftUpdateCheck = 1250;
1356-
LastUpgradeCheck = 1530;
1356+
LastUpgradeCheck = 1630;
13571357
ORGANIZATIONNAME = "Guilherme Rambo";
13581358
TargetAttributes = {
13591359
DD36A4AB1E478C6900B2EA88 = {
@@ -1857,7 +1857,6 @@
18571857
DD36A4BC1E478C6A00B2EA88 /* Debug */ = {
18581858
isa = XCBuildConfiguration;
18591859
buildSettings = {
1860-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
18611860
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
18621861
CLANG_ENABLE_MODULES = YES;
18631862
CODE_SIGN_ENTITLEMENTS = WWDC/WWDC.entitlements;
@@ -1886,7 +1885,6 @@
18861885
DD36A4BD1E478C6A00B2EA88 /* Release */ = {
18871886
isa = XCBuildConfiguration;
18881887
buildSettings = {
1889-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
18901888
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
18911889
CLANG_ENABLE_MODULES = YES;
18921890
CODE_SIGN_ENTITLEMENTS = WWDC/WWDC.entitlements;
@@ -1976,7 +1974,6 @@
19761974
DD5910651ECA0C17003C32A4 /* Debug_iCloud */ = {
19771975
isa = XCBuildConfiguration;
19781976
buildSettings = {
1979-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
19801977
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
19811978
CLANG_ENABLE_MODULES = YES;
19821979
CODE_SIGN_ENTITLEMENTS = WWDC/WWDCDebug_iCloud.entitlements;
@@ -2060,7 +2057,6 @@
20602057
DD59106A1ECA0C20003C32A4 /* Release_iCloud */ = {
20612058
isa = XCBuildConfiguration;
20622059
buildSettings = {
2063-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
20642060
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
20652061
CLANG_ENABLE_MODULES = YES;
20662062
CODE_SIGN_ENTITLEMENTS = WWDC/WWDCRelease_iCloud.entitlements;
@@ -2094,6 +2090,7 @@
20942090
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
20952091
CLANG_ENABLE_MODULES = YES;
20962092
CLANG_ENABLE_OBJC_WEAK = YES;
2093+
CODE_SIGN_IDENTITY = "";
20972094
CODE_SIGN_STYLE = Automatic;
20982095
COMBINE_HIDPI_IMAGES = YES;
20992096
DEAD_CODE_STRIPPING = YES;
@@ -2129,6 +2126,7 @@
21292126
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
21302127
CLANG_ENABLE_MODULES = YES;
21312128
CLANG_ENABLE_OBJC_WEAK = YES;
2129+
CODE_SIGN_IDENTITY = "";
21322130
CODE_SIGN_STYLE = Automatic;
21332131
COMBINE_HIDPI_IMAGES = YES;
21342132
DEAD_CODE_STRIPPING = YES;
@@ -2164,6 +2162,7 @@
21642162
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
21652163
CLANG_ENABLE_MODULES = YES;
21662164
CLANG_ENABLE_OBJC_WEAK = YES;
2165+
CODE_SIGN_IDENTITY = "";
21672166
CODE_SIGN_STYLE = Automatic;
21682167
COMBINE_HIDPI_IMAGES = YES;
21692168
DEAD_CODE_STRIPPING = YES;
@@ -2197,6 +2196,7 @@
21972196
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
21982197
CLANG_ENABLE_MODULES = YES;
21992198
CLANG_ENABLE_OBJC_WEAK = YES;
2199+
CODE_SIGN_IDENTITY = "";
22002200
CODE_SIGN_STYLE = Automatic;
22012201
COMBINE_HIDPI_IMAGES = YES;
22022202
DEAD_CODE_STRIPPING = YES;
@@ -2325,6 +2325,7 @@
23252325
isa = XCBuildConfiguration;
23262326
buildSettings = {
23272327
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2328+
CODE_SIGN_IDENTITY = "";
23282329
COMBINE_HIDPI_IMAGES = YES;
23292330
DEAD_CODE_STRIPPING = YES;
23302331
DEFINES_MODULE = YES;
@@ -2356,6 +2357,7 @@
23562357
isa = XCBuildConfiguration;
23572358
buildSettings = {
23582359
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2360+
CODE_SIGN_IDENTITY = "";
23592361
COMBINE_HIDPI_IMAGES = YES;
23602362
DEAD_CODE_STRIPPING = YES;
23612363
DEFINES_MODULE = YES;
@@ -2387,6 +2389,7 @@
23872389
isa = XCBuildConfiguration;
23882390
buildSettings = {
23892391
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2392+
CODE_SIGN_IDENTITY = "";
23902393
COMBINE_HIDPI_IMAGES = YES;
23912394
DEAD_CODE_STRIPPING = YES;
23922395
DEFINES_MODULE = YES;
@@ -2418,6 +2421,7 @@
24182421
isa = XCBuildConfiguration;
24192422
buildSettings = {
24202423
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
2424+
CODE_SIGN_IDENTITY = "";
24212425
COMBINE_HIDPI_IMAGES = YES;
24222426
DEAD_CODE_STRIPPING = YES;
24232427
DEFINES_MODULE = YES;

‎WWDC.xcodeproj/xcshareddata/xcschemes/WWDC.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1530"
3+
LastUpgradeVersion = "1630"
44
version = "1.8">
55
<BuildAction
66
parallelizeBuildables = "YES"

‎WWDC.xcodeproj/xcshareddata/xcschemes/WWDC_iCloud.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1530"
3+
LastUpgradeVersion = "1630"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

‎WWDC/AppCoordinator+Bookmarks.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ extension AppCoordinator: PUITimelineDelegate, VideoPlayerViewControllerDelegate
6868

6969
}
7070

71-
extension Bookmark: PUITimelineAnnotation {
71+
extension Bookmark: @retroactive PUITimelineAnnotation {
7272

7373
public var isEmpty: Bool {
7474
return body.isEmpty

‎WWDC/AppDelegate.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ class AppDelegate: NSObject, NSApplicationDelegate, Logging {
6161

6262
urlObservationToken = NotificationCenter.default.addObserver(forName: .openWWDCURL, object: nil, queue: .main) { [weak self] note in
6363
guard let url = note.object as? URL else { return }
64-
self?.openURL(url)
64+
MainActor.assumeIsolated {
65+
self?.openURL(url)
66+
}
6567
}
6668

6769
let item = DispatchWorkItem(block: showMigrationSplashScreen)

‎WWDC/Boot.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,4 +238,4 @@ extension NSApplication {
238238
}
239239
}
240240

241-
extension NSWorkspace: @unchecked Sendable { }
241+
extension NSWorkspace: @retroactive @unchecked Sendable { }

‎WWDC/ImageDownloadCenter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ final class ImageCacheProvider {
234234

235235
}
236236

237-
private final class ImageDownloadOperation: Operation {
237+
private final class ImageDownloadOperation: Operation, @unchecked Sendable {
238238

239239
private var completionHandlers: [ImageDownloadCompletionBlock] = []
240240

‎WWDC/MediaDownload/Integration/DownloadedContentMonitor.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Cocoa
22
import ConfCore
33
import OSLog
44

5-
final class DownloadedContentMonitor: Logging {
5+
final class DownloadedContentMonitor: Logging, @unchecked Sendable {
66
static let log = makeLogger()
77

88
var storage: Storage?
@@ -118,8 +118,6 @@ final class DownloadedContentMonitor: Logging {
118118
var files: [String] = []
119119

120120
while let url = enumerator.nextObject() as? URL {
121-
let path = url.path
122-
123121
if enumerator.level > 2 { enumerator.skipDescendants() }
124122

125123
/// Special handling for HLS downloads, which are a movpkg bundle.

‎WWDC/MediaDownload/Support/String+Error.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Foundation
22

3-
extension String: LocalizedError {
3+
extension String: @retroactive LocalizedError {
44
public var errorDescription: String? { self }
55
}

0 commit comments

Comments
 (0)