feat: Add feature version for avif_codecs #28
Conversation
This exposes the value from avifCodecVersions, which would allow users of the library to confirm the versions of codecs before trying to use codec-specific options (such as tune=iq or avif=1 in aom and SVT-AV1, respectively).
|
I think it kind of clutters features.py, and I don't think
is very friendly. If I suggest |
|
I like that, and I don't disagree with you about the ugliness of the interface. Unfortunately, libavif doesn't return anything beyond this semi-structured string. In its own code (e.g. avifenc) they will string-parse the versions from this string. If I make certain assumptions about the format of avifCodecVersions I could use a regular expression to build a dictionary. Or I could ask the maintainers of libavif if they could provide a better interface. Thoughts? |
|
ping @radarhere in case you're not getting notifications for this PR. |
|
It sounds like you have an argument that if people want to check for the availability of codec-specific options, then there should be an easier way to check that availability in C. If you think that's a worthwhile endeavour separate to Pillow, then sure, raise it with them. However, I don't personally think the current form is a blocker for inclusion in Pillow. I've created #29 |
Skip failing WMF records on 32-bit Windows
This exposes the value from
avifCodecVersions(), which would allow users of the library to confirm the versions of codecs before trying to use codec-specific options (such as tune=iq or avif=1 in aom and SVT-AV1, respectively).cc: @radarhere