fix: deduplicate variable names in no-loop-func error messages (#19595)

snitin315 · web-flow · commit b23d1c5f0297 · 2025-04-03T09:32:36.000+02:00
* fix: deduplicate variable names in no-loop-func error messages

* chore: fix lint
diff --git a/lib/rules/no-loop-func.js b/lib/rules/no-loop-func.js
@@ -237,9 +237,13 @@ module.exports = {
 				}
 			}
 
-			const unsafeRefs = references
-				.filter(r => r.resolved && !isSafe(loopNode, r))
-				.map(r => r.identifier.name);
+			const unsafeRefs = [
+				...new Set(
+					references
+						.filter(r => r.resolved && !isSafe(loopNode, r))
+						.map(r => r.identifier.name),
+				),
+			];
 
 			if (unsafeRefs.length > 0) {
 				context.report({
diff --git a/tests/lib/rules/no-loop-func.js b/tests/lib/rules/no-loop-func.js
@@ -740,5 +740,28 @@ ruleTester.run("no-loop-func", rule, {
 				},
 			],
 		},
+		{
+			code: `
+            for (var i = 0; i < 10; i++) {
+				items.push({
+					id: i,
+					name: "Item " + i
+				});
+
+				const process = function (callback){
+					callback({ id: i, name: "Item " + i });
+				};
+			}
+            `,
+			languageOptions: { ecmaVersion: 2022 },
+			errors: [
+				{
+					messageId: "unsafeRefs",
+					data: { varNames: "'i'" },
+					type: "FunctionExpression",
+					line: 8,
+				},
+			],
+		},
 	],
 });
