Skip to content

DAOS-17687 container: fix potential memory leaks #16508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DAOS-17687 container: fix potential memory leaks #16508

wants to merge 1 commit into from
+45 −45

Conversation

wangshilong
Copy link
Contributor

For some pool/container operations, if they fail due to timeout, the system will retry. However, if the retry also fails, we need to free the task private allocation if it exists.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions GitHub Actions
Copy link

Ticket title is 'Potential memory leaks triggered by CI'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-17687

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16508/1/execution/node/1355/log

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16508/1/testReport/

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16508/1/execution/node/1495/log

@wangshilong
DAOS-17687 container: fix potential memory leaks
b3c7994 
For some pool/container operations, if they fail due to timeout,
the system will retry. However, if the retry also fails, we need
to free the task private allocation if it exists.

Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
@wangshilong wangshilong force-pushed the shilongw/DAOS-17687 branch from 63abc0c to b3c7994 Compare June 17, 2025 08:05
@wangshilong wangshilong marked this pull request as ready for review June 17, 2025 08:07
@wangshilong wangshilong requested review from a team as code owners June 17, 2025 08:07
liw
liw approved these changes Jun 17, 2025
View reviewed changes
src/container/cli.c
Comment on lines 432 to 435
err_task:
if (tpriv != NULL)
cont_task_destroy_priv(task);
tse_task_complete(task, rc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very clear. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liw liw liw approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangshilong @daosbuild3 @liw @NiuYawei