Refactor the SlimdumpCommand, DumpTask and Dumper classes #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few refactorings that make the
SlimdumpCommand
,DumpTask
andDumper
classes and method signatures more straightforward:MysqlOutputFormatDriver
inSlimdumpCommand
, we can pass it the necessary information from command line switches directly. No need to pass-through these flags and settings through other classes/methods.OutputInterface
given toMysqlOutputFormatDriver
(for writing out SQL) from theOutputInterface
passed toDumper
(where it is used to output progress information)NullOutput
for the progress-relatedOutputInterface
instead of passing a$noProgress
boolean through several methods. Saves us a bunch ofif
-conditionals.