Skip to content

[BUG] datadog admission controller breaks deployments using sidecars #37837

Open
@bob-bins

Description

@bob-bins

On version 3.118.0 of the DataDog Helm Chart, the DataDog admission controller (for this K8s label admission.datadoghq.com/enabled: true) incorrectly removes the restartPolicy property in a pod-to-be if it's specified in an initContainer. This causes any ReplicaSet containing a sidecar container with probes to break - they will be unable to create Pods given that only Sidecar containers can have probes, not "normal init containers".

Until this is fixed, we are unable to use the DataDog admission controller on any Deployments containing sidecar containers.

Is this just a matter of updating the k8s.io/api package here? Given that the sidecar container feature was made stable in v0.33 (it was beta in 0.32)

k8s.io/api v0.32.3

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions