utils.parse: fix ignore_ns in parse_xml #4075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
utils/parse/xml
branch
from
51331e5 to
4964595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4074
What's broken is the regex for removing the namespace data, which expects a leading space or tab character, which doesn't work when a new-line or a different whitespace character is used in the serialized XML content. I've added another test for that.
There's probably a better solution for stripping default namespace information than using a dirty regex substitution, but this simple fix should work for now (and I don't want to re-implement the parse_xml method).
https://lxml.de/parsing.html#parsers