[WIP] Add support for Mavlink over handset CRSF #2841
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/lib/MAVLink/MAVLink.cpp
LupusTheCanine
force-pushed
the
crsf-mavlink
branch
from
3f8e546 to
f1a00cb
Compare
IamPete1
reviewed
Jul 14, 2024
| mavlink_status_t status; | ||
| for(uint8_t i=0; i<size;i++) | ||
| { | ||
| if(mavlink_parse_char(MAVLINK_COMM_1,SerialInBuffer[4+i],&msg,&status)) |
There was a problem hiding this comment.
This use of MAVLINK_COMM_1 will mean we need to bump MAVLINK_COMM_NUM_BUFFERS to 2. #2846
* Added config option for runtime enabling/disabling MAVLink over CRSF
* Added compile time option to set custom source and destination system id
TX_SYSID (source system ID)
RX_SYSID (target system ID)
LupusTheCanine
force-pushed
the
crsf-mavlink
branch
from
91b43ed to
1a7463b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for sending Mavlink to handset over CRSF as well as receiving mavlink over CRSF from handset allowing almost native support for telemetry and GCS scripts (after switching from Yaapu's "mavlite" to full mavlink).
TODO
Requires EdgeTX/edgetx#5243 for operation as EdgeTX can freeze due to a bug in CRSF processing.
I need help with adding configuration.
I was thinking about using link mode to indicate if Mavlink should be sent and accepted over CRSF.