Skip to content

plugins.afreeca: Support for password-protected streams #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2024
Merged

plugins.afreeca: Support for password-protected streams #5952

merged 1 commit into from
Apr 20, 2024

Conversation

B4TT3RY
Copy link
Contributor

@B4TT3RY B4TT3RY commented Apr 19, 2024

When I used the correct password:

$ streamlink --loglevel debug --afreeca-stream-password 71 https://play.afreecatv.com/ecvhao/263153658
NoTagError: `git describe --long --dirty --always --tags` could not find a tag
[cli][debug] OS:         Linux-6.5.13-1-pve-x86_64-with-glibc2.39
[cli][debug] Python:     3.11.8
[cli][debug] OpenSSL:    OpenSSL 3.2.1 30 Jan 2024
[cli][debug] Streamlink: 0.0.0+unknown
[cli][debug] Dependencies:
[cli][debug]  certifi: 2024.2.2
[cli][debug]  exceptiongroup: 1.2.1
[cli][debug]  isodate: 0.6.1
[cli][debug]  lxml: 5.2.1
[cli][debug]  pycountry: 23.12.11
[cli][debug]  pycryptodome: 3.20.0
[cli][debug]  PySocks: 1.7.1
[cli][debug]  requests: 2.31.0
[cli][debug]  trio: 0.25.0
[cli][debug]  trio-websocket: 0.11.1
[cli][debug]  typing-extensions: 4.11.0
[cli][debug]  urllib3: 2.2.1
[cli][debug]  websocket-client: 1.7.0
[cli][debug] Arguments:
[cli][debug]  url=https://play.afreecatv.com/ecvhao/263153658
[cli][debug]  --loglevel=debug
[cli][debug]  --afreeca-stream-password=71
[plugins.afreeca][debug] Restored cookies: _au, _au3rd
[cli][info] Found matching plugin afreeca for URL https://play.afreecatv.com/ecvhao/263153658
Available streams: sd (worst), hd, original (best)

When I used the wrong password:

$ streamlink --loglevel debug --afreeca-stream-password wrong_password https://play.afreecatv.com/ecvhao/263153658
NoTagError: `git describe --long --dirty --always --tags` could not find a tag
[cli][debug] OS:         Linux-6.5.13-1-pve-x86_64-with-glibc2.39
[cli][debug] Python:     3.11.8
[cli][debug] OpenSSL:    OpenSSL 3.2.1 30 Jan 2024
[cli][debug] Streamlink: 0.0.0+unknown
[cli][debug] Dependencies:
[cli][debug]  certifi: 2024.2.2
[cli][debug]  exceptiongroup: 1.2.1
[cli][debug]  isodate: 0.6.1
[cli][debug]  lxml: 5.2.1
[cli][debug]  pycountry: 23.12.11
[cli][debug]  pycryptodome: 3.20.0
[cli][debug]  PySocks: 1.7.1
[cli][debug]  requests: 2.31.0
[cli][debug]  trio: 0.25.0
[cli][debug]  trio-websocket: 0.11.1
[cli][debug]  typing-extensions: 4.11.0
[cli][debug]  urllib3: 2.2.1
[cli][debug]  websocket-client: 1.7.0
[cli][debug] Arguments:
[cli][debug]  url=https://play.afreecatv.com/ecvhao/263153658
[cli][debug]  --loglevel=debug
[cli][debug]  --afreeca-stream-password=wrong_password
[plugins.afreeca][debug] Restored cookies: _au, _au3rd
[cli][info] Found matching plugin afreeca for URL https://play.afreecatv.com/ecvhao/263153658
[plugins.afreeca][error] Stream is Password-Protected
error: No playable streams found on this URL: https://play.afreecatv.com/ecvhao/263153658

bastimeyer
bastimeyer reviewed Apr 19, 2024
View reviewed changes
@bastimeyer bastimeyer added the plugin enhancement A new feature for a working Plugin label Apr 19, 2024
@B4TT3RY
Copy link
Contributor Author

B4TT3RY commented Apr 20, 2024

I tried fixing it, but I'm not sure if this is the right way to do it since I'm not very good with Python.
In my opinion, this will create conflicts with other PRs.

bastimeyer
bastimeyer reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this will create conflicts with other PRs.

There will be merge conflicts anyway because you've opened two PRs (with separate branches - obviously).

Just rebase and force-push once the other PR got merged. Force-pushing with rebased/amended commits is always better than adding multiple commits to the branch, because I'll have to squash-merge in this case. I can review rebased and force-pushed branches just fine, even complex ones. This one here is dead simple.

bastimeyer
bastimeyer reviewed Apr 20, 2024
View reviewed changes
@bastimeyer bastimeyer force-pushed the plugins/afreeca/support-stream-password branch from 02cc2d6 to 8ea10ee Compare April 20, 2024 15:15
@bastimeyer bastimeyer merged commit 293ceb1 into streamlink:master Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastimeyer bastimeyer bastimeyer left review comments

Assignees
No one assigned
Labels
plugin enhancement A new feature for a working Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B4TT3RY @bastimeyer