plugins.tvp: rewrite and fix plugin #6535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
plugins/tvp/fix-6534
branch
from
08ab96a to
8c90dd5
Compare
|
Hi @bastimeyer thank you very much. LGTM. The nice thing is that two mainstream 24x7 streams are streamlinkable with their static URLs, there's no need to select a broadcast: Debug logs below. Live streamsShows / tv series / other on demandNewsOther - paywall |
|
Thanks for checking...
That's the result of the URL matcher not making use of the optional show ID. As talked about, I'm not sure if past shows are still accessible with those IDs, so it's currently ignored and it simply uses the ID of the channel. Going to merge now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6534
@ybp-mm Please have a look at this PR. See if there are any streams which are not working and report back with a debug log of the streams you've tested. I could only check ones which are available with a German IP address (info and world).
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
As commented in #6534, live streams have moved from
stream.tvp.pl/tvpstream.vod.tvp.pltovod.tvp.pl. In order to keep the actual VOD matcher simple, a separate matcher is being used for live streams. When getting the stream ID, thevideoTyperequest param simply needs to be "LIVE" rather than "MOVIE". VODs which are paywalled now show an error message instead of a validation schema error stack.The
tvp.infosite also required some changes. The channel's live stream (at least) had a different video type "SG", which requires two additional API requests for getting the actual stream ID. The "NEWS" type for news article VODs was already implemented and seemed to still work, but it's all region-blocked. According to their JS, there's a third type "VIDEO". No idea about that...sport.tvp.plseemed to be still working...