-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.tvp: rewrite and fix plugin #6535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
08ab96a
to
8c90dd5
Compare
Hi @bastimeyer thank you very much. LGTM. The nice thing is that two mainstream 24x7 streams are streamlinkable with their static URLs, there's no need to select a broadcast: Debug logs below. Live streams
Shows / tv series / other on demand
News
Other - paywall
|
Thanks for checking...
That's the result of the URL matcher not making use of the optional show ID. As talked about, I'm not sure if past shows are still accessible with those IDs, so it's currently ignored and it simply uses the ID of the channel. Going to merge now... |
Fixes #6534
@ybp-mm Please have a look at this PR. See if there are any streams which are not working and report back with a debug log of the streams you've tested. I could only check ones which are available with a German IP address (info and world).
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
As commented in #6534, live streams have moved from
stream.tvp.pl
/tvpstream.vod.tvp.pl
tovod.tvp.pl
. In order to keep the actual VOD matcher simple, a separate matcher is being used for live streams. When getting the stream ID, thevideoType
request param simply needs to be "LIVE" rather than "MOVIE". VODs which are paywalled now show an error message instead of a validation schema error stack.The
tvp.info
site also required some changes. The channel's live stream (at least) had a different video type "SG", which requires two additional API requests for getting the actual stream ID. The "NEWS" type for news article VODs was already implemented and seemed to still work, but it's all region-blocked. According to their JS, there's a third type "VIDEO". No idea about that...sport.tvp.pl
seemed to be still working...