Skip to content

Make CSS attr types definition list items #40418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Make CSS attr types definition list items #40418

merged 1 commit into from
Jul 18, 2025

Conversation

hamishwillee
Copy link
Collaborator

This makes the options of https://developer.mozilla.org/en-US/docs/Web/CSS/attr#attr-type into definition list items.
This allows them to be linked, including from BCD, and is IMO always good practice

Related to discussion in mdn/browser-compat-data#26624 (review)

@hamishwillee hamishwillee requested a review from a team as a code owner July 18, 2025 00:18
@hamishwillee hamishwillee requested review from estelle and removed request for a team July 18, 2025 00:18
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 18, 2025
@hamishwillee hamishwillee mentioned this pull request Jul 18, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (4)

URL: /en-US/docs/Web/CSS/attr
Title: attr()
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/declaration-value
    • Can't resolve /en-US/docs/Web/CSS/ident-token
    • Can't resolve /en-US/docs/Web/CSS/ident-token
    • Can't resolve /en-US/docs/Web/CSS/attr-unit

dipikabh
dipikabh approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@dipikabh dipikabh merged commit db98052 into mdn:main Jul 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @dipikabh