Uses a non const variable to illustrate the assignment in equality check #40442
Conversation
github-actions
bot
added
Content:Learn
|
Preview URLs (comment last updated: 2025-07-19 11:23:43) |
| ``` | ||
|
|
||
| the test would always return `true`, causing the program to report that the game has been won. Be careful! | ||
| the test would always return `true`, causing the program to `setGameOver()` after the first wrong guess. Be careful! |
There was a problem hiding this comment.
Wrong; it would throw an error instead
There was a problem hiding this comment.
Thanks @Josh-Cena for reviewing. I am unable to reproduce the error (FF 128). Could you please share the message/screenshot?
There was a problem hiding this comment.
Did you intend to change const guessCount to let guessCount? Because that's not reflected in your PR. If you don't change that (I would prefer if you don't), then this line would throw an error instead.
There was a problem hiding this comment.
This file references the code from here which has let guessCount already. userGuess is const and that's why I've not used it to illustrate the issue. Hope this works. Thanks.
There was a problem hiding this comment.
Oh! I see what you are doing. That's a really good approach.
Description
The assignment check used a
constvariable. Changed to one that usedletMotivation
Additional details
Thanks @Goal-max for reporting
Related issues and pull requests
Fixes #39332