Skip to content

Commit a8a3fc8

Browse files
softworkzmichaelni
authored andcommitted
avformat/hls: Partially revert "reduce default max reload to 3"
(setting to 100 as a reasonable compromise) The change has caused regressions for many users and consumers. Playlist reloads only happen when a playlist doesn't indicate that it has ended (via #EXT-X-ENDLIST), which means that the addition of future segments is still expected. It is well possible that an HLS server is temporarily unable to serve further segments but resumes after some time, either indicating a discontinuity or even by fully catching up. With a segment length of 3s, a max_reload value of 1000 corresponds to a duration of 50 minutes which appears to be a reasonable default. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit ace9f03) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
1 parent 71889a8 commit a8a3fc8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

libavformat/hls.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2633,7 +2633,7 @@ static const AVOption hls_options[] = {
26332633
{"extension_picky", "Be picky with all extensions matching",
26342634
OFFSET(extension_picky), AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, FLAGS},
26352635
{"max_reload", "Maximum number of times a insufficient list is attempted to be reloaded",
2636-
OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 3}, 0, INT_MAX, FLAGS},
2636+
OFFSET(max_reload), AV_OPT_TYPE_INT, {.i64 = 100}, 0, INT_MAX, FLAGS},
26372637
{"m3u8_hold_counters", "The maximum number of times to load m3u8 when it refreshes without new segments",
26382638
OFFSET(m3u8_hold_counters), AV_OPT_TYPE_INT, {.i64 = 1000}, 0, INT_MAX, FLAGS},
26392639
{"http_persistent", "Use persistent HTTP connections",

0 commit comments

Comments
 (0)