json schema: fix Criterion Object #338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfiel
reviewed
Apr 24, 2025
| - simple | ||
| - regex | ||
| - jsonpath | ||
| - xpath | ||
| default: simple | ||
| - $ref: '#/$defs/criterion-expression-type-object' | ||
| type: string |
There was a problem hiding this comment.
unnecessary because the enums are only strings
Suggested change
| type: string |
| type: | ||
| description: The type of condition to be applied | ||
| default: simple | ||
| oneOf: |
|
@markus-96 thanks for the PR. Would you be able to take a look at the feedback from @jeremyfiel? Also, can you target |
|
@markus-96 appreciate your patience here. I was holding off on approving during to pending infra changes. Those infra changes are not merged, and we've changed the schema directory locations to align with the OpenAPI Specification repos. Would you be able to update your PR to make the changes against the new schema locations, and also take a look at @jeremyfiel comments above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #336
this is my first PR to this project, so I am happy if you tell me if it meets your expectations :)
If needed, I can also try to take part in the meeting coming in two weeks.
reading #337 (comment) ("Need to digest #336 before discussing"), maybe this helps:
I would consider the following class diagram for modelling a Criterion Object: