Optimize Staff::EntertainerUpdateNearbyPeeps

This function is quite bad with a large amount of guests.
https://github.com/OpenRCT2/OpenRCT2/blob/32f652e493f9e927cc59c3889c1bf0e056a099a2/src/openrct2/entity/Staff.cpp#L867-L897

We can use the spatial mapping to only get nearby guests rather than iterating the entirety of all guests, with 100 entertainers and 50'000 guests this will result in 5'000'000 iterations just to find guests that are are at most 3 tiles away, very wasteful.

Credits to @lordmarcel for his "Limit park"

	void Staff::EntertainerUpdateNearbyPeeps() const
	{
	for (auto guest : EntityList<Guest>())
	{
	if (guest->x == kLocationNull)
	continue;

	int16_t z_dist = abs(z - guest->z);
	if (z_dist > 48)
	continue;

	int16_t x_dist = abs(x - guest->x);
	int16_t y_dist = abs(y - guest->y);

	if (x_dist > 96)
	continue;

	if (y_dist > 96)
	continue;

	if (guest->State == PeepState::Walking)
	{
	guest->HappinessTarget = std::min(guest->HappinessTarget + 4, kPeepMaxHappiness);
	}
	else if (guest->State == PeepState::Queuing)
	{
	guest->TimeInQueue = std::max(0, guest->TimeInQueue - 200);
	guest->HappinessTarget = std::min(guest->HappinessTarget + 3, kPeepMaxHappiness);
	}
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Optimize Staff::EntertainerUpdateNearbyPeeps #24260

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Optimize Staff::EntertainerUpdateNearbyPeeps #24260

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions