Skip to content

Replace display options tab with custom sprites #23857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

spacek531
Copy link
Contributor

@spacek531 spacek531 commented Feb 20, 2025

Replaces the display settings tab with CRT monitor sprites.

sprite_0

@spacek531
Copy link
Contributor Author

Should this get a changelog?

@AaronVanGeffen AaronVanGeffen changed the title Replace options tab sprites with custom sprites Replace display options tab with custom sprites Feb 20, 2025
@Gymnasiast Gymnasiast added this to the v0.4.20 milestone Feb 20, 2025
@AaronVanGeffen
Copy link
Member

Overall, I really like the new icon. I'm a bit torn on what it looks like on the blue window/tab background, though. To me, the colours clash a bit. Thinking, maybe the screen could be a little smaller in width (1 or 2 pixels?) with a bit more contrast on the edges? Not sure if that would work.

Fwiw, this is what it currently looks like for me:

Screenshot 2025-02-21 at 16 09 54

@Gymnasiast Gymnasiast removed this from the v0.4.20 milestone Feb 24, 2025
Copy link

This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

@AaronVanGeffen AaronVanGeffen force-pushed the opengraphics/add-monitor-tab branch 2 times, most recently from 61f67e7 to 1da57ea Compare April 17, 2025 11:18
@AaronVanGeffen
Copy link
Member

I've rebased this PR, as I'd really like to have these sprites in for the display tab. However, I still think the display 'beige' clashes slightly with the blue. What do others think?

@Gymnasiast
Copy link
Member

I think it’s fine.

@Gymnasiast Gymnasiast merged commit 2249dff into OpenRCT2:develop Apr 17, 2025
23 checks passed
@Gymnasiast Gymnasiast added this to the v0.4.22 milestone Apr 17, 2025
AaronVanGeffen added a commit that referenced this pull request May 4, 2025
- Feature: [#24206] [Plugin] Add APIs for breaking down rides, reading the current breakdown, and for fixing broken down rides.
- Improved: [#20073] The OpenGL drawing engine now supports screen invalidation which avoids the redrawing of unchanged regions.
- Improved: [#21767] RCT Classic for macOS can now be used as the source game.
- Improved: [#23590] Title bars are now drawn bigger when “Enlarged UI” is enabled.
- Improved: [#23626] Add small, medium and large flat and sloped turns, S-bends and diagonal track to the Go-Karts.
- Improved: [#23982] The scenario objective window has been merged into the scenario options window.
- Improved: [#24233] RCT Classic+ from Apple Arcade can now be used as the source game, and is detected automatically.
- Improved: [#24260] Better performance on parks that have a lot of Guests and Entertainers.
- Improved: [#24319] RCT Classic installs via Steam are now detected automatically on Windows.
- Change: [#23803] Lightning strikes and thunder now happen at the same frequency independently of the game speed.
- Change: [#23857] Replace display options tab with custom sprites.
- Change: [#24069] [Plugin] Plugins are now available in the scenario editor and track designer.
- Change: [#24135] Compress Emscripten js/wasm files.
- Change: [#24194] The advanced options tab has been reworked to make it easier to find the RCT1 path setting.
- Change: [#24235] Small changes to RCT1 theme.
- Change: [#24236] Controls and Interface options now both have their own tabs in the Options window.
- Change: [#24308] “Software” and “Software (hardware display)” renderers have been merged into a single “Software” renderer.
- Change: [#24317] The scenery window now shows at least one row of scenery objects, even if there are multiple rows of tabs.
- Fix: [#18479] Tile elements ordered beneath water do not draw correctly.
- Fix: [#19782] Game stops counting inversions and golf holes after 31 (original bug).
- Fix: [#21207] Track List window gets positioned incorrectly.
- Fix: [#21919] Non-recolourable cars still show colour picker (original bug).
- Fix: [#22182] [Plugin] Crash when using map.getAllEntities("car").
- Fix: [#22634] Asset packs with sound effect overrides are not loaded correctly at startup.
- Fix: [#23108] Missing pieces on Hypercoaster and Hyper-Twister, even with the ‘all drawable track pieces’ cheat enabled.
- Fix: [#24013] Failure to load a scenario preview image (minimap) could lead to an uncaught exception error message.
- Fix: [#24045] [Plugin] Data storage is not cleared when converting save game to scenario.
- Fix: [#24121] Checkbox labels run beyond the edge of the window if they’re too long to fit.
- Fix: [#24142] [Plugin] Track origin is miscalculated on downward slopes.
- Fix: [#24220] Narrow station platforms have missing sides on certain rotations.
- Fix: [#24286] Steam installs of RCT1 and RCT2 are not autodetected on macOS.
- Fix: [#24310] [Plugin] Missing invalidation on various plugin api setters for entities.
tupaschoal pushed a commit to klusark/OpenRCT2 that referenced this pull request Aug 6, 2025
- Feature: [OpenRCT2#24206] [Plugin] Add APIs for breaking down rides, reading the current breakdown, and for fixing broken down rides.
- Improved: [OpenRCT2#20073] The OpenGL drawing engine now supports screen invalidation which avoids the redrawing of unchanged regions.
- Improved: [OpenRCT2#21767] RCT Classic for macOS can now be used as the source game.
- Improved: [OpenRCT2#23590] Title bars are now drawn bigger when “Enlarged UI” is enabled.
- Improved: [OpenRCT2#23626] Add small, medium and large flat and sloped turns, S-bends and diagonal track to the Go-Karts.
- Improved: [OpenRCT2#23982] The scenario objective window has been merged into the scenario options window.
- Improved: [OpenRCT2#24233] RCT Classic+ from Apple Arcade can now be used as the source game, and is detected automatically.
- Improved: [OpenRCT2#24260] Better performance on parks that have a lot of Guests and Entertainers.
- Improved: [OpenRCT2#24319] RCT Classic installs via Steam are now detected automatically on Windows.
- Change: [OpenRCT2#23803] Lightning strikes and thunder now happen at the same frequency independently of the game speed.
- Change: [OpenRCT2#23857] Replace display options tab with custom sprites.
- Change: [OpenRCT2#24069] [Plugin] Plugins are now available in the scenario editor and track designer.
- Change: [OpenRCT2#24135] Compress Emscripten js/wasm files.
- Change: [OpenRCT2#24194] The advanced options tab has been reworked to make it easier to find the RCT1 path setting.
- Change: [OpenRCT2#24235] Small changes to RCT1 theme.
- Change: [OpenRCT2#24236] Controls and Interface options now both have their own tabs in the Options window.
- Change: [OpenRCT2#24308] “Software” and “Software (hardware display)” renderers have been merged into a single “Software” renderer.
- Change: [OpenRCT2#24317] The scenery window now shows at least one row of scenery objects, even if there are multiple rows of tabs.
- Fix: [OpenRCT2#18479] Tile elements ordered beneath water do not draw correctly.
- Fix: [OpenRCT2#19782] Game stops counting inversions and golf holes after 31 (original bug).
- Fix: [OpenRCT2#21207] Track List window gets positioned incorrectly.
- Fix: [OpenRCT2#21919] Non-recolourable cars still show colour picker (original bug).
- Fix: [OpenRCT2#22182] [Plugin] Crash when using map.getAllEntities("car").
- Fix: [OpenRCT2#22634] Asset packs with sound effect overrides are not loaded correctly at startup.
- Fix: [OpenRCT2#23108] Missing pieces on Hypercoaster and Hyper-Twister, even with the ‘all drawable track pieces’ cheat enabled.
- Fix: [OpenRCT2#24013] Failure to load a scenario preview image (minimap) could lead to an uncaught exception error message.
- Fix: [OpenRCT2#24045] [Plugin] Data storage is not cleared when converting save game to scenario.
- Fix: [OpenRCT2#24121] Checkbox labels run beyond the edge of the window if they’re too long to fit.
- Fix: [OpenRCT2#24142] [Plugin] Track origin is miscalculated on downward slopes.
- Fix: [OpenRCT2#24220] Narrow station platforms have missing sides on certain rotations.
- Fix: [OpenRCT2#24286] Steam installs of RCT1 and RCT2 are not autodetected on macOS.
- Fix: [OpenRCT2#24310] [Plugin] Missing invalidation on various plugin api setters for entities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants