Skip to content

chore(ui/icons): convert Answer Overflow logo to next/font #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2023

Conversation

JoltCode
Copy link
Collaborator

Description

  • Adds story for Answer Overflow logo component
  • Converts font on Answer Overflow logo to using next/font
  • Removes any imports of the Poppins font

Fixes #83 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated .env.example if I added a new environment variable
  • My PR title follows the semantic commits style

@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
answer-overflow-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 9:19am

@vercel
Copy link

vercel bot commented May 19, 2023

@JoltCode is attempting to deploy a commit to the Answer Overflow Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #400 (c8cfea2) into main (df45307) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   70.02%   70.02%           
=======================================
  Files          73       73           
  Lines        2409     2409           
  Branches      606      606           
=======================================
  Hits         1687     1687           
  Misses        649      649           
  Partials       73       73           

@JoltCode JoltCode marked this pull request as ready for review May 19, 2023 09:56
@JoltCode JoltCode requested a review from RhysSullivan May 19, 2023 09:56
@RhysSullivan RhysSullivan merged commit 28dc9ea into AnswerOverflow:main May 19, 2023
@JoltCode JoltCode deleted the ao-next-logo-font branch May 19, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚛ component Issue relates to a react component 🖥️website Relates to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use @next/font for logo svg
2 participants