IRunnerReporter doesn't work in 2.8.1 #2968
-
|
We've been running our tests with XUnit 2.4.1 for a while. We are now trying to skip several versions and get up to the latest 2.8.1. I've changed xunit and xunit.runner.utility from 2.4.1 to 2.8.1, and xunit.runner.visualstudio from 2.4.3 to 2.8.1. Included in our personal test framework are classes that implement IRunnerReporter. According to examples I found, it registers an XUnitMessageSink object. XUnitMessageSink has been inheriting from IMessageSink and IMessageSinkWithTypes. After the upgrade, I found that the compiler also required it to inherit from LongLivedMarshalByRefObject for some reason. But when I run my tests now, I'm finding that is not finding and instantiating the IRunnerReporter. This in turn, means that my XUnitMessageSink class is not able to detect events coming from XUnit. What more do I need to do to get this working again? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 3 replies
-
This has always been true. However, it only recently got surfaced to you because we added analyzers to highlight this fact.
Can you provide a repro project with the reporter? |
Beta Was this translation helpful? Give feedback.
-
Well, it always worked for me before it became an error! 😄
No need. I figured it out. Turns out this was predicted in the 2.5.0 Release Notes in the second bullet point in the Extensibility section. All I had to do to fix it was to to pull the class implementing IRunnerReporter into a new project that has "reporters" in its name, make it depend on my base test project to register the message sink and listener, and have the test projects that need the listener depend on the "reporters" as well as the base test project. Then it worked just like before. |
Beta Was this translation helpful? Give feedback.
-
If you don't use .NET Framework, then the issue likely never comes up. It doesn't change the "requirement", but the "fake" implementation of xunit/src/common/LongLivedMarshalByRefObject.cs Lines 57 to 68 in 80a2294 |
Beta Was this translation helpful? Give feedback.
-
|
@jchesshirAspire, Can you please share a sample project with suggested workaround i.e. |
Beta Was this translation helpful? Give feedback.
-
|
No, there are no changes planned for this. |
Beta Was this translation helpful? Give feedback.
Well, it always worked for me before it became an error! 😄
No need. I figured it out. Turns out this was predicted in the 2.5.0 Release Notes in the second bullet point in the Extensibility section. All I had to do to fix it was to to pull the class implementing IRunnerReporter into a new proje…