plugins.twitch: refactor worker, parser and tests #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the custom parameters and properties from the parser and adds the "prefetch" field to the namedtuple Segment. - Filters out prefetch segments in the worker's process_sequences method - Replaces the playlist_reloads counter with a playlist_sequence == -1 check, which is sufficient for checking the beginning of the stream. - Adds had_content property to worker, which checks for segments which are not ads until the first segment was found. - Refactors the info log messages and fixes the "This is not a low latency stream" message when preroll ads exist. - Cleans up tests - Adds more tests for certain low-latency and disable-ads conditions.
Codecov Report
@@ Coverage Diff @@
## master #3169 +/- ##
==========================================
- Coverage 52.67% 52.62% -0.05%
==========================================
Files 244 244
Lines 15636 15626 -10
==========================================
- Hits 8236 8223 -13
- Misses 7400 7403 +3 |
|
This PR is a combination of three things
And I've cleaned up the tests and added a few more for certain low-latency and disable-ads conditions. This doesn't fix the timeout "issue" when filtering out mid-stream ads, which I've talked about in the other thread. |
gravyboat
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
@bastimeyer This looks good, I'm almost tempted to say we should include a link to the pinned issue about commercials in the text for the commercial break segment to try and head off any additional issues/comments. If you don't agree feel free to merge this as is.
|
No, let's not add links to debug/info log messages. These links will become obsolete quickly. |
1 task
resiproxy
pushed a commit
to resiproxy/streamlink
that referenced
this pull request
Nov 5, 2020
- Removes the custom parameters and properties from the parser and adds the "prefetch" field to the namedtuple Segment. - Filters out prefetch segments in the worker's process_sequences method - Replaces the playlist_reloads counter with a playlist_sequence == -1 check, which is sufficient for checking the beginning of the stream. - Adds had_content property to worker, which checks for segments which are not ads until the first segment was found. - Refactors the info log messages and fixes the "This is not a low latency stream" message when preroll ads exist. - Cleans up tests - Adds more tests for certain low-latency and disable-ads conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the "prefetch" field to the namedtuple Segment.
check, which is sufficient for checking the beginning of the stream.
are not ads until the first segment was found.
"This is not a low latency stream" message when preroll ads exist.