-
Notifications
You must be signed in to change notification settings - Fork 689
Open
Labels
Description
The text in the counts for the admin cert put and validate seem to have been copied from QueryCert but not cleaned to match the admin cert functions
this is an admin cert failure but the counts mention quertCert
shardeum/src/handlers/adminCertificate.ts
Lines 23 to 73 in 0bf267b
| function validatePutAdminCertRequest(req: PutAdminCertRequest, shardus: Shardus): ValidatorError { | |
| const publicKey = shardus.crypto.getPublicKey() | |
| if (!req.nominee || req.nominee === '' || req.nominee.length !== 64 || req.nominee != publicKey) { | |
| /* prettier-ignore */ nestedCountersInstance.countEvent('shardeum-admin-certificate', `validatePutAdminCertRequest fail req.nominee address invalid`) | |
| /* prettier-ignore */ if (ShardeumFlags.VerboseLogs) console.log('validatePutAdminCertRequest fail req.nominee address invalid', req) | |
| return { success: false, reason: 'Invalid nominee address' } | |
| } | |
| try { | |
| if (!crypto.verifyObj(req)) return { success: false, reason: 'Invalid signature for AdminCert' } | |
| } catch (e) { | |
| return { success: false, reason: 'Invalid signature for QueryCert tx' } | |
| } | |
| try { | |
| const pkClearance = shardus.getDevPublicKey(req.sign.owner) | |
| if(pkClearance == null){ | |
| return { success: false, reason: 'Unauthorized! no getDevPublicKey defined' } | |
| } | |
| if ( | |
| pkClearance && | |
| (!shardus.crypto.verify(req, pkClearance) || | |
| shardus.ensureKeySecurity(pkClearance, DevSecurityLevel.High) === false) | |
| ) | |
| return { success: false, reason: 'Unauthorized! Please use higher level auth key.' } | |
| } catch (e) { | |
| return { success: false, reason: 'Invalid signature for QueryCert tx' } | |
| } | |
| return { success: true, reason: '' } | |
| } | |
| export async function putAdminCertificateHandler( | |
| req: Request, | |
| shardus: Shardus | |
| ): Promise<PutAdminCertResult | ValidatorError> { | |
| nestedCountersInstance.countEvent('shardeum-admin-certificate', 'calling queryCertificateHandler') | |
| const certReq = req.body as PutAdminCertRequest | |
| const reqValidationResult = validatePutAdminCertRequest(certReq, shardus) | |
| if (!reqValidationResult.success) { | |
| nestedCountersInstance.countEvent( | |
| 'shardeum-admin-certificate', | |
| 'queryCertificateHandler: failed validateQueryCertRequest' | |
| ) | |
| return reqValidationResult | |
| } | |
| return { success: true, signedAdminCert: certReq } | |
| } |