Skip to content

[CWS] add a ringbuf usage threshold #36755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[CWS] add a ringbuf usage threshold #36755

wants to merge 5 commits into from
+102 −30

Conversation

safchain
Copy link
Contributor

@safchain safchain commented May 7, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@safchain safchain added changelog/no-changelog team/agent-security category/improvement qa/done QA done before merge and regressions are covered by tests labels May 7, 2025
@github-actions github-actions bot added component/system-probe medium review PR review might take time labels May 7, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 7, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor dbdd6efa00f78125822d81e78a9c8fa7ef3fadb0

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.45MB ⚠️ 774.97MB 774.52MB 0.50MB
datadog-agent-x86_64-rpm 0.45MB ⚠️ 783.91MB 783.46MB 0.50MB
datadog-agent-x86_64-suse 0.45MB ⚠️ 783.91MB 783.46MB 0.50MB
datadog-agent-aarch64-rpm 0.45MB ⚠️ 773.30MB 772.85MB 0.50MB
datadog-agent-arm64-deb 0.45MB ⚠️ 764.37MB 763.92MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.21MB 31.21MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 31.30MB 31.30MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.04MB 30.04MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 377.96MB 377.96MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 60.63MB 60.63MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 60.71MB 60.71MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 60.71MB 60.71MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 57.92MB 57.92MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 58.00MB 58.00MB 0.50MB

Decision

⚠️ Warning

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented May 7, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 62059fa9-02ee-43cd-8213-fcbb5722e86a

Baseline: e7b7917
Comparison: 40b2bc7
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ tcp_syslog_to_blackhole ingress throughput +1.18 [+1.11, +1.25] 1 Logs
➖ file_tree memory utilization +1.15 [+0.93, +1.37] 1 Logs
➖ quality_gate_logs % cpu utilization +0.63 [-2.18, +3.43] 1 Logs bounds checks dashboard
➖ otlp_ingest_metrics memory utilization +0.59 [+0.42, +0.75] 1 Logs
➖ quality_gate_idle memory utilization +0.50 [+0.42, +0.58] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.36 [+0.23, +0.50] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +0.17 [+0.04, +0.30] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.10 [-0.51, +0.71] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.49, +0.59] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.56, +0.62] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.02 [-0.59, +0.63] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.57, +0.61] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.00 [-0.60, +0.60] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.29, +0.28] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.01 [-0.24, +0.23] 1 Logs
➖ ddot_logs memory utilization -0.02 [-0.14, +0.10] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.64, +0.55] 1 Logs
➖ ddot_metrics memory utilization -0.05 [-0.17, +0.07] 1 Logs
➖ docker_containers_cpu % cpu utilization -0.17 [-3.13, +2.78] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.48 [-0.53, -0.43] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.75 [-1.65, +0.15] 1 Logs
➖ docker_containers_memory memory utilization -1.04 [-1.12, -0.96] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_logs memory_usage 9/10 bounds checks dashboard
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 7, 2025 •
edited
Loading

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor e7b7917

Error

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
❌ agent_deb_amd64 $${+0.45}$$ $${697.46}$$ > $${697.37}$$ $${+26.72}$$ $${176.11}$$ < $${177.03}$$
❌ agent_deb_amd64_fips $${+0.44}$$ $${695.76}$$ > $${695.59}$$ $${+25.48}$$ $${175.54}$$ < $${176.51}$$
❌ agent_rpm_amd64 $${+0.45}$$ $${697.45}$$ > $${697.36}$$ $${+25.88}$$ $${177.65}$$ < $${178.56}$$
❌ agent_rpm_amd64_fips $${+0.44}$$ $${695.74}$$ > $${695.58}$$ $${+24.93}$$ $${177.53}$$ < $${178.43}$$
❌ agent_rpm_arm64 $${+0.44}$$ $${687.47}$$ > $${687.37}$$ $${+22.88}$$ $${161.14}$$ < $${161.99}$$
❌ agent_rpm_arm64_fips $${+0.45}$$ $${685.88}$$ > $${685.72}$$ $${+21.51}$$ $${160.28}$$ < $${161.11}$$
❌ agent_suse_amd64 $${+0.45}$$ $${697.45}$$ > $${697.36}$$ $${+25.88}$$ $${177.65}$$ < $${178.56}$$
❌ agent_suse_amd64_fips $${+0.44}$$ $${695.74}$$ > $${695.58}$$ $${+24.93}$$ $${177.53}$$ < $${178.43}$$
❌ agent_suse_arm64 $${+0.44}$$ $${687.47}$$ > $${687.37}$$ $${+22.88}$$ $${161.14}$$ < $${161.99}$$
❌ agent_suse_arm64_fips $${+0.45}$$ $${685.88}$$ > $${685.72}$$ $${+21.51}$$ $${160.28}$$ < $${161.11}$$
❌ docker_agent_amd64 $${+0.45}$$ $${781.25}$$ > $${781.16}$$ $${+0.04}$$ $${268.82}$$ < $${269.63}$$
❌ docker_agent_arm64 $${+0.44}$$ $${794.72}$$ > $${794.62}$$ $${+0.04}$$ $${256.18}$$ < $${257.0}$$
❌ docker_agent_jmx_amd64 $${+0.45}$$ $${972.45}$$ > $${972.35}$$ $${+0.06}$$ $${337.81}$$ < $${338.6}$$
❌ docker_agent_jmx_arm64 $${+0.44}$$ $${974.51}$$ > $${974.41}$$ $${+0.05}$$ $${321.12}$$ < $${321.97}$$
Gate failure full details
Quality gate Error type Error message
agent_deb_amd64 AssertionError Package size on disk (uncompressed package size) 731343368 is higher than the maximum allowed 731245445 by the gate !
agent_deb_amd64_fips AssertionError Package size on disk (uncompressed package size) 729552398 is higher than the maximum allowed 729378979 by the gate !
agent_rpm_amd64 AssertionError Package size on disk (uncompressed package size) 731331989 is higher than the maximum allowed 731234959 by the gate !
agent_rpm_amd64_fips AssertionError Package size on disk (uncompressed package size) 729541019 is higher than the maximum allowed 729368494 by the gate !
agent_rpm_arm64 AssertionError Package size on disk (uncompressed package size) 720866779 is higher than the maximum allowed 720759685 by the gate !
agent_rpm_arm64_fips AssertionError Package size on disk (uncompressed package size) 719199898 is higher than the maximum allowed 719029534 by the gate !
agent_suse_amd64 AssertionError Package size on disk (uncompressed package size) 731331989 is higher than the maximum allowed 731234959 by the gate !
agent_suse_amd64_fips AssertionError Package size on disk (uncompressed package size) 729541019 is higher than the maximum allowed 729368494 by the gate !
agent_suse_arm64 AssertionError Package size on disk (uncompressed package size) 720866779 is higher than the maximum allowed 720759685 by the gate !
agent_suse_arm64_fips AssertionError Package size on disk (uncompressed package size) 719199898 is higher than the maximum allowed 719029534 by the gate !
docker_agent_amd64 AssertionError Image size on disk (uncompressed image size) 819202474 is higher than the maximum allowed 819105628 by the gate !
docker_agent_arm64 AssertionError Image size on disk (uncompressed image size) 833327460 is higher than the maximum allowed 833219461 by the gate !
docker_agent_jmx_amd64 AssertionError Image size on disk (uncompressed image size) 1019683343 is higher than the maximum allowed 1019582873 by the gate !
docker_agent_jmx_arm64 AssertionError Image size on disk (uncompressed image size) 1021852713 is higher than the maximum allowed 1021742940 by the gate !

Static quality gates prevent the PR to merge! You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_heroku_amd64 $${0}$$ $${358.67}$$ < $${359.67}$$ $${+11.32}$$ $${96.51}$$ < $${97.47}$$
✅ agent_msi $${+0}$$ $${958.89}$$ < $${959.86}$$ $${-0.01}$$ $${146.29}$$ < $${147.27}$$
✅ docker_agent_windows1809 $${+0.38}$$ $${1487.03}$$ < $${1488.0}$$ $${+0.18}$$ $${488.0}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${+0}$$ $${6216.99}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${6338.56}$$ < $${6361.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1608.66}$$ < $${1609.5}$$ $${-0.02}$$ $${530.28}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${-0}$$ $${1506.13}$$ < $${1507.0}$$ $${+0.03}$$ $${500.8}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${+0}$$ $${6190.05}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${+0}$$ $${6311.69}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${+0}$$ $${1627.91}$$ < $${1628.16}$$ $${-0.02}$$ $${543.04}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${212.84}$$ < $${213.79}$$ $${+0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${228.68}$$ < $${229.64}$$ $${+0}$$ $${68.65}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${-0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${39.22}$$ < $${39.57}$$ $${-0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0.08}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${+0.09}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0.08}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0.08}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0.25}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0.22}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${+0}$$ $${11.2}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0.26}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0.23}$$ $${11.16}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0.26}$$ $${12.86}$$ < $${13.81}$$

@safchain safchain force-pushed the safchain/discarder-perf branch from bec89bf to 81a291c Compare May 14, 2025 16:50
@safchain safchain force-pushed the safchain/discarder-perf branch from ae78033 to 1d0cb86 Compare June 13, 2025 14:44
@safchain safchain force-pushed the safchain/discarder-perf branch from 1d0cb86 to 40b2bc7 Compare June 17, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/improvement changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@safchain