Skip to content

Multi-Account Containers #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 4, 2025
Merged

Multi-Account Containers #45

merged 12 commits into from
Jan 4, 2025

Conversation

Arttii
Copy link
Contributor

@Arttii Arttii commented Dec 18, 2024

Hi,

Thanks for the great script. I added the functionality to selected containers for new tabs and for existing ones as well. I did not have enough time to figure out how to reinit the entire WebPanel on container change, so changing a tab container after creation needs a restart currently.

The code is quite hacky, but it works and can be used as a jumping off point.

Additionally, I wanted to add notification tracking, but honestly, I could not find out which APIs FF uses to display the red change marker for a tab. Any ideas?

Fixes #24

@aminought
Copy link
Owner

@Arttii Not working for me, sorry... But thanks anyway, I'll try to fix it. Don't worry about authorship, I'll save your commits.

@aminought aminought marked this pull request as draft January 3, 2025 05:16
@Arttii
Copy link
Contributor Author

Arttii commented Jan 3, 2025

@aminought Strange, I have been running it for the last few weeks. Thanks for taking a look and fixing it though!

@aminought
Copy link
Owner

aminought commented Jan 3, 2025

@Arttii It seems that script starts too fast, so the ContextualIdentityService does not have time to fully load. The containers started working after adding a delay before injection of the sidebar. Thanks a lot, it's very cool, but I need some time to polish it.

@aminought aminought marked this pull request as ready for review January 4, 2025 07:27
@aminought
Copy link
Owner

@Arttii Done. It would be nice if you could help me with the testing.

@aminought aminought changed the title Add containers Multi-Account Containers Jan 4, 2025
@Arttii
Copy link
Contributor Author

Arttii commented Jan 4, 2025

@aminought Thanks for all the fixes! It seems to work pretty well, from just my general usage. The switching works great as well. I'll post here if I run into any bugs. Do you have any specific scenarios in mind?

The only thing I noticed is that there is a largish gray border on the right side of the open Web Panel, but this might be an issue on my side.

image

@aminought
Copy link
Owner

@Arttii I don't know, it seems that I've already tested and fixed the main scenarios, now I'm trying to find and fix some minor bugs.

"a largish gray border" is unrelated to this pull request and I can't reproduce it, sorry.

@aminought
Copy link
Owner

@Arttii By the way, I've added an option to customize the container indicator, check Sidebar Settings.

@aminought aminought merged commit 96bceaf into aminought:master Jan 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Select which container the web panel opens with
2 participants