Skip to content

Multi period content support for AdsMediaSource #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Multi period content support for AdsMediaSource #2501

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
22c58d9
Ads on multi period content
kotucz Jun 2, 2025
6775405
Test MultiPeriodAdTimeline
kotucz Jun 2, 2025
1c14b2c
Add multi period DASH sample with ads
kotucz Jun 2, 2025
eb0467b
Special case for post-roll ads
kotucz Jun 3, 2025
e38f026
Post-roll ads test
kotucz Jun 3, 2025
ce4464c
Rename parameter
kotucz Jun 4, 2025
2ba33bc
Add java doc
kotucz Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test MultiPeriodAdTimeline
  • Loading branch information
@kotucz
kotucz committed Jun 2, 2025
commit 67754051b8bd1c618a15a312d7e16ac45bb2e50a
79 changes: 79 additions & 0 deletions ...oplayer/src/test/java/androidx/media3/exoplayer/source/ads/MultiPeriodAdTimelineTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
package androidx.media3.exoplayer.source.ads;

import static androidx.media3.common.C.INDEX_UNSET;
import static androidx.media3.common.C.MICROS_PER_SECOND;
import static androidx.media3.test.utils.FakeTimeline.FAKE_MEDIA_ITEM;
import static org.junit.Assert.assertEquals;

import androidx.media3.common.AdPlaybackState;
import androidx.media3.common.Timeline.Period;
import androidx.media3.test.utils.FakeTimeline;
import org.junit.Test;

public class MultiPeriodAdTimelineTest {
@Test
public void getPeriod() {
String windowId = "windowId";

FakeTimeline contentTimeline = new FakeTimeline(
new FakeTimeline.TimelineWindowDefinition(
3, // periodCount
windowId,
true, // isSeekable
false, // isDynamic
false, // isLive
false, // isPlaceholder
60 * MICROS_PER_SECOND, // durationUs
0, // defaultPositionUs
0, // windowOffsetInFirstPeriodUs
AdPlaybackState.NONE, // adPlaybackState
FAKE_MEDIA_ITEM // mediaItem
)
);

MultiPeriodAdTimeline multiPeriodAdTimeline = new MultiPeriodAdTimeline(
contentTimeline, new AdPlaybackState(
"adsId",
0L, 10 * MICROS_PER_SECOND, // period 0: 0s - 20s
25 * MICROS_PER_SECOND, 35 * MICROS_PER_SECOND, // period 1: 20s - 40s
45 * MICROS_PER_SECOND, 55 * MICROS_PER_SECOND // period 2: 40s - 60s
));

Period period0 = new Period();
multiPeriodAdTimeline.getPeriod(0, period0);

// period durations are uniformly split windowDuration/periodCount
assertEquals(20 * MICROS_PER_SECOND, period0.durationUs);

// positions within the 0th period
assertEquals(0, period0.getAdGroupIndexForPositionUs(1 * MICROS_PER_SECOND));
assertEquals(1, period0.getAdGroupIndexAfterPositionUs(1 * MICROS_PER_SECOND));
assertEquals(1, period0.getAdGroupIndexForPositionUs(19 * MICROS_PER_SECOND));
// no more ads to be played in 0th period
assertEquals(INDEX_UNSET, period0.getAdGroupIndexAfterPositionUs(19 * MICROS_PER_SECOND));

Period period1 = new Period();
multiPeriodAdTimeline.getPeriod(1, period1);

// positions within the 1st period
assertEquals(1, period1.getAdGroupIndexForPositionUs(1 * MICROS_PER_SECOND));
assertEquals(2, period1.getAdGroupIndexAfterPositionUs(1 * MICROS_PER_SECOND));
assertEquals(2, period1.getAdGroupIndexForPositionUs(10 * MICROS_PER_SECOND));
assertEquals(3, period1.getAdGroupIndexAfterPositionUs(10 * MICROS_PER_SECOND));
assertEquals(3, period1.getAdGroupIndexForPositionUs(19 * MICROS_PER_SECOND));
// no more ads to be played in 1st period
assertEquals(INDEX_UNSET, period1.getAdGroupIndexAfterPositionUs(19 * MICROS_PER_SECOND));

Period period2 = new Period();
multiPeriodAdTimeline.getPeriod(2, period2);

// positions within the 2nd period
assertEquals(3, period2.getAdGroupIndexForPositionUs(1 * MICROS_PER_SECOND));
assertEquals(4, period2.getAdGroupIndexAfterPositionUs(1 * MICROS_PER_SECOND));
assertEquals(4, period2.getAdGroupIndexForPositionUs(10 * MICROS_PER_SECOND));
assertEquals(5, period2.getAdGroupIndexAfterPositionUs(10 * MICROS_PER_SECOND));
assertEquals(5, period2.getAdGroupIndexForPositionUs(19 * MICROS_PER_SECOND));
// no more ads to be played in 2nd period
assertEquals(INDEX_UNSET, period2.getAdGroupIndexAfterPositionUs(19 * MICROS_PER_SECOND));
}
}