Skip to content

feat(codegen): use existing types in operations with preResolveTypes … #10368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

usama-liaqat
Copy link

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.


Description

This merge request updates the GraphQL Codegen configuration to support using existing type definitions with the client preset. Specifically, it introduces the preResolveTypes option in presetConfig so that operation files reference shared types (e.g., from @graphql-codegen/typescript) instead of generating inline duplicates.

This change improves maintainability and reduces redundancy across the codebase.

Related #10367


Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots/Sandbox (if appropriate/relevant):

N/A – configuration-only change affecting generated TypeScript output.


How Has This Been Tested?

  • Ran graphql-codegen locally with the updated config.
  • Verified that generated operation files reference existing types from shared output (types.ts) instead of creating inline ones.

Test Environment:

  • OS: macOS/Linux/Windows
  • @graphql-codegen/...: [insert version used]
  • NodeJS: [insert version used]

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

The client preset produces clean modular output but always generates inline operation types. With preResolveTypes, we can now reuse existing types (already generated separately), reducing duplication and improving consistency.

This feature is opt-in and has no breaking changes.

Copy link

changeset-bot bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: 05e7664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant