eMMC Update Handler Refactoring #1752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove the unused part_active_str variable. Fixes: fa87117 ("src/update_handler: update boot partition reporting") Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
This avoids some code duplication. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1752 +/- ##
==========================================
+ Coverage 84.51% 84.52% +0.01%
==========================================
Files 76 76
Lines 22384 22375 -9
==========================================
- Hits 18917 18913 -4
+ Misses 3467 3462 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zentax-dev
reviewed
Jul 4, 2025
Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
In img_to_boot_emmc_handler(), instead of creating the dummy 'part_slot', we temporarily set the 'device' of the original slot to the eMMC boot partition device. This is a preparation for the follow up refactoring commit. The main purpose is to allow using the same slot for the hooks as we use for the actual copying. To keep the hook env consistent, manually override the RAUC_SLOT_DEVICE with the original eMMC base device. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
The scope of this method is to update an eMMC boot partition with the necessary force_ro disabling and re-enabling. This allows to encapsulate the force_ro error path handling and provides a method that can be used for emmc updates that don't require a boot partition switch. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
Since we don't need the goto label anymore, we can use immediate returns now. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
This adds a bootloader slot to the system.conf in case eMMC support is available. This allows to interactively test eMMC handling. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
ejoerns
force-pushed
the
update-handler-emmc
branch
from
e44c924 to
980d062
Compare
zentax-dev
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to fixing a minor bug and improving manual testing of eMMC boot partition handling, this removes some unnecessary code duplication and prepares for a broader use of the eMMC update handling.