Skip to content

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Aug 12, 2025

Description

  • Added in page example of match-element value of view-transition-name property and removed link to external demo
  • Linked to example from View Transition API page

Motivation

Related issues and pull requests

@dletorey dletorey requested review from a team as code owners August 12, 2025 16:34
@dletorey dletorey requested review from chrisdavidmills and sideshowbarker and removed request for a team August 12, 2025 16:34
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Aug 12, 2025
Copy link
Contributor

github-actions bot commented Aug 12, 2025

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/View_Transition_API
Title: View Transition API
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/CSS/:active-view-transition-type

(comment last updated: 2025-08-19 10:27:59)

@dletorey dletorey requested review from dipikabh and bsmth and removed request for chrisdavidmills and sideshowbarker August 12, 2025 16:36
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - it's great to have an example in the page instead of linking out!

My comments are a bit out of order, they're not in the same sequence as the sections on the page. Also, I've suggested edits for prose outside the scope of this PR where I think a bit of rephrasing can help to better clarify the concepts.

dletorey and others added 9 commits August 18, 2025 11:10
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey dletorey requested a review from dipikabh August 18, 2025 10:15
dletorey and others added 13 commits August 18, 2025 14:06
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey dletorey requested a review from dipikabh August 19, 2025 10:26
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look great! 👍 Thanks a lot :)

@dipikabh dipikabh merged commit 157426c into mdn:main Aug 19, 2025
8 checks passed
@dletorey dletorey deleted the 40479-vt-name-match-element branch August 19, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants