Skip to content

plugins.twitch: fix metadata API response handling #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bastimeyer
Copy link
Member

Fixes #3206

Since I want to refactor the entire plugin at some point anyway, I decided to add validation schemas for the metadata API responses instead of just adding a simple is not None check. Also added tests with mocked API responses.

I don't know if the videos API response can be empty, similar to the "channel from stream" response, but better safe than sorry.

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Oct 4, 2020
@gravyboat
Copy link
Member

gravyboat commented Oct 4, 2020

Looks good, thanks @bastimeyer.

@gravyboat gravyboat merged commit 6de76fc into streamlink:master Oct 4, 2020
@bastimeyer bastimeyer deleted the plugins/twitch/fix-metadata-api-response-handling branch October 9, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--title switch with variable arguments prevents Twitch rerun vod from playing
2 participants