Skip to content

chore(ui/storybook): change storybook postcss addon #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 6, 2023

Conversation

JoltCode
Copy link
Collaborator

@JoltCode JoltCode commented May 5, 2023

Description

Change storybook postcss addon from @storybook/addon-postcss to @storybook/addon-styling
Updated all other storybook packages

This also restores functionality of all other plugins in the storybook preview toolbar.

Fixes #376 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated .env.example if I added a new environment variable
  • My PR title follows the semantic commits style

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
answer-overflow-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 5:00pm

@vercel
Copy link

vercel bot commented May 5, 2023

@JoltCode is attempting to deploy a commit to the Answer Overflow Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #384 (3be9429) into main (90be3a0) will increase coverage by 70.25%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main     #384       +/-   ##
=========================================
+ Coverage      0   70.25%   +70.25%     
=========================================
  Files         0       73       +73     
  Lines         0     2394     +2394     
  Branches      0      603      +603     
=========================================
+ Hits          0     1682     +1682     
- Misses        0      640      +640     
- Partials      0       72       +72     

see 73 files with indirect coverage changes

@RhysSullivan RhysSullivan merged commit 04b5996 into AnswerOverflow:main May 6, 2023
@JoltCode JoltCode deleted the storybook-postcss branch May 6, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥️website Relates to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev Env]: Migrate from @storybook/addon-postcss to @storybook/addon-styling
2 participants