Skip to content

Commit 2fee9bc

Browse files
committed
build(cmake): remove unnecessary lines
1 parent cbd4b78 commit 2fee9bc

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

.github/actions/apt-fetch-clang/action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ name: Fetch Clang toolchain on Linux
22

33
inputs:
44
llvm-ver:
5-
required: false
6-
default: 17
5+
required: true
76
runs:
87
using: composite
98

.github/workflows/build-and-test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ jobs:
2525

2626
- name: Fetch Clang
2727
uses: ./.github/actions/apt-fetch-clang
28+
with:
29+
llvm-ver: 17
2830

2931
- name: Get cmake option
3032
id: cmake-option
@@ -76,7 +78,7 @@ jobs:
7678

7779
- uses: ilammy/msvc-dev-cmd@v1
7880
with:
79-
toolset: 14.38
81+
toolset: 14.39
8082

8183
- name: CMake build and test (Debug)
8284
uses: ./.github/actions/cmake-build-and-test

cmake/Utils.cmake

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,6 @@ if("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
1313
add_compile_options(/utf-8 /diagnostics:caret)
1414
endif()
1515

16-
if("${CMAKE_BUILD_TYPE}" MATCHES "Debug")
17-
message(STATUS "Debug mode.\n")
18-
else()
19-
message(
20-
STATUS
21-
"Current config is ${CMAKE_BUILD_TYPE}, not Debug mode, add NDEBUG definition\n"
22-
)
23-
add_compile_definitions("NDEBUG")
24-
endif()
25-
2616
include(ProcessorCount)
2717

2818
ProcessorCount(PROCESSOR_COUNT)

0 commit comments

Comments
 (0)