utils.args: update num() argparse utility function #5239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
utils/args/update-num
branch
from
1ea095b to
1651a69
Compare
- Replace `min` and `max` with `ge`, `gt`, `le` and `lt` - Update and fix params/values of numeric CLI argparser arguments - Rewrite `num()` tests
bastimeyer
force-pushed
the
utils/args/update-num
branch
from
1651a69 to
501ac2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minandmaxwithge,gt,leandltnum()testsThis rewrite is required for being able to add numeric CLI args which allow a min value of 0. This is currently not possible, as
num()is checking forvalue >= min. Min values of int args were set to -1 because of this, but this doesn't work for float args (there currently are none of that kind, but I'm intending to add one).--player-external-http-porthad an incorrect min value, as the default is set to 0--stream-segment-threadsis now properly clamped between 1 and 10geinstead ofgt