Skip to content

ci(pr-test): qualify files to build properly #28408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

ci(pr-test): qualify files to build properly #28408

merged 1 commit into from
Aug 15, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Aug 14, 2025

Description

Fixes the pr-test workflow.

Motivation

Fix the pr-test workflow. Since $PWD refers to mdn/content, it doesn't work without changing folders first.

Additional details

Related issues and pull requests

Follow-up of #28386.

@caugner caugner requested a review from a team as a code owner August 14, 2025 19:23
@caugner caugner changed the title ci(pr-test): qualifiy files to build properly ci(pr-test): qualify files to build properly Aug 14, 2025
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Aug 14, 2025
@caugner caugner requested a review from argl August 14, 2025 19:27
@@ -153,7 +153,8 @@ jobs:

ARGS=()
for file in "${files_to_build[@]}"; do
ARGS+=("-f" "$PWD/$file")
file_without_prefix="${file#files/}"
Copy link
Contributor Author

@caugner caugner Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I checked locally that this removes files/ only once (given that there are some pages about files attributes that include /files/ twice).

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR will fix the broken workflow, can we merge it sooner?

@argl argl merged commit eaba7a6 into main Aug 15, 2025
10 checks passed
@argl argl deleted the fix-test-workflow branch August 15, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants