Skip to content

Commit 85364ff

Browse files
keithamusChromium LUCI CQ
keithamus
authored and
Chromium LUCI CQ
committed
Enable command & commandfor by default.
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/ctNbl4gWLuk/m/NXmcIDLlAQAJ. Merged spec PR: whatwg/html#9841. Bug: 40284894 Change-Id: I2c37dd8eb968948de420d673c0a21bcddf2bf75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6281568 Reviewed-by: Luke <lwarlow@igalia.com> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425940}
1 parent d7f486d commit 85364ff

7 files changed

+47
-1
lines changed

‎android_webview/test/data/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,6 +1175,11 @@ interface CloseWatcher : EventTarget
11751175
method requestClose
11761176
setter oncancel
11771177
setter onclose
1178+
interface CommandEvent : Event
1179+
attribute @@toStringTag
1180+
getter command
1181+
getter source
1182+
method constructor
11781183
interface Comment : CharacterData
11791184
attribute @@toStringTag
11801185
method constructor
@@ -1685,6 +1690,7 @@ interface Document : Node
16851690
getter onchange
16861691
getter onclick
16871692
getter onclose
1693+
getter oncommand
16881694
getter oncontentvisibilityautostatechange
16891695
getter oncontextlost
16901696
getter oncontextmenu
@@ -1904,6 +1910,7 @@ interface Document : Node
19041910
setter onchange
19051911
setter onclick
19061912
setter onclose
1913+
setter oncommand
19071914
setter oncontentvisibilityautostatechange
19081915
setter oncontextlost
19091916
setter oncontextmenu
@@ -3227,6 +3234,8 @@ interface HTMLBodyElement : HTMLElement
32273234
setter vLink
32283235
interface HTMLButtonElement : HTMLElement
32293236
attribute @@toStringTag
3237+
getter command
3238+
getter commandForElement
32303239
getter disabled
32313240
getter form
32323241
getter formAction
@@ -3247,6 +3256,8 @@ interface HTMLButtonElement : HTMLElement
32473256
method constructor
32483257
method reportValidity
32493258
method setCustomValidity
3259+
setter command
3260+
setter commandForElement
32503261
setter disabled
32513262
setter formAction
32523263
setter formEnctype
@@ -3364,6 +3375,7 @@ interface HTMLElement : Element
33643375
getter onchange
33653376
getter onclick
33663377
getter onclose
3378+
getter oncommand
33673379
getter oncontentvisibilityautostatechange
33683380
getter oncontextlost
33693381
getter oncontextmenu
@@ -3499,6 +3511,7 @@ interface HTMLElement : Element
34993511
setter onchange
35003512
setter onclick
35013513
setter onclose
3514+
setter oncommand
35023515
setter oncontentvisibilityautostatechange
35033516
setter oncontextlost
35043517
setter oncontextmenu
@@ -5232,6 +5245,7 @@ interface MathMLElement : Element
52325245
getter onchange
52335246
getter onclick
52345247
getter onclose
5248+
getter oncommand
52355249
getter oncontentvisibilityautostatechange
52365250
getter oncontextlost
52375251
getter oncontextmenu
@@ -5343,6 +5357,7 @@ interface MathMLElement : Element
53435357
setter onchange
53445358
setter onclick
53455359
setter onclose
5360+
setter oncommand
53465361
setter oncontentvisibilityautostatechange
53475362
setter oncontextlost
53485363
setter oncontextmenu
@@ -7184,6 +7199,7 @@ interface SVGElement : Element
71847199
getter onchange
71857200
getter onclick
71867201
getter onclose
7202+
getter oncommand
71877203
getter oncontentvisibilityautostatechange
71887204
getter oncontextlost
71897205
getter oncontextmenu
@@ -7297,6 +7313,7 @@ interface SVGElement : Element
72977313
setter onchange
72987314
setter onclick
72997315
setter onclose
7316+
setter oncommand
73007317
setter oncontentvisibilityautostatechange
73017318
setter oncontextlost
73027319
setter oncontextmenu
@@ -10982,6 +10999,7 @@ namespace console
1098210999
getter onchange
1098311000
getter onclick
1098411001
getter onclose
11002+
getter oncommand
1098511003
getter oncontentvisibilityautostatechange
1098611004
getter oncontextlost
1098711005
getter oncontextmenu
@@ -11198,6 +11216,7 @@ namespace console
1119811216
setter onchange
1119911217
setter onclick
1120011218
setter onclose
11219+
setter oncommand
1120111220
setter oncontentvisibilityautostatechange
1120211221
setter oncontextlost
1120311222
setter oncontextmenu

‎third_party/blink/renderer/platform/runtime_enabled_features.json5

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2353,9 +2353,10 @@
23532353
// Adds support for the `command` and `commandfor` attributes, as specified
23542354
// in the open-ui "Invokers" explainer.
23552355
// https://open-ui.org/components/invokers.explainer/
2356+
// This feature was shipped in M135 and can be removed in M137.
23562357
{
23572358
name: "HTMLCommandAttributes",
2358-
status: "experimental",
2359+
status: "stable",
23592360
},
23602361
{
23612362
// TODO(crbug.com/376516550): Enables dialog light dismiss functionality.

‎third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ PASS oldChildWindow.oncanplaythrough is newChildWindow.oncanplaythrough
118118
PASS oldChildWindow.onchange is newChildWindow.onchange
119119
PASS oldChildWindow.onclick is newChildWindow.onclick
120120
PASS oldChildWindow.onclose is newChildWindow.onclose
121+
PASS oldChildWindow.oncommand is newChildWindow.oncommand
121122
PASS oldChildWindow.oncontentvisibilityautostatechange is newChildWindow.oncontentvisibilityautostatechange
122123
PASS oldChildWindow.oncontextlost is newChildWindow.oncontextlost
123124
PASS oldChildWindow.oncontextmenu is newChildWindow.oncontextmenu

‎third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ PASS childWindow.oncanplaythrough is null
7777
PASS childWindow.onchange is null
7878
PASS childWindow.onclick is null
7979
PASS childWindow.onclose is null
80+
PASS childWindow.oncommand is null
8081
PASS childWindow.oncontentvisibilityautostatechange is null
8182
PASS childWindow.oncontextlost is null
8283
PASS childWindow.oncontextmenu is null

‎third_party/blink/web_tests/virtual/stable/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ PASS childWindow.oncanplaythrough is null
7777
PASS childWindow.onchange is null
7878
PASS childWindow.onclick is null
7979
PASS childWindow.onclose is null
80+
PASS childWindow.oncommand is null
8081
PASS childWindow.oncontentvisibilityautostatechange is null
8182
PASS childWindow.oncontextlost is null
8283
PASS childWindow.oncontextmenu is null

‎third_party/blink/web_tests/virtual/stable/webexposed/element-instance-property-listing-expected.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ namespace http://www.w3.org/1999/xhtml
191191
property onchange
192192
property onclick
193193
property onclose
194+
property oncommand
194195
property oncontentvisibilityautostatechange
195196
property oncontextlost
196197
property oncontextmenu
@@ -489,6 +490,8 @@ html element br
489490
property clear
490491
html element button
491492
property checkValidity
493+
property command
494+
property commandForElement
492495
property disabled
493496
property form
494497
property formAction
@@ -1408,6 +1411,7 @@ namespace http://www.w3.org/2000/svg
14081411
property onchange
14091412
property onclick
14101413
property onclose
1414+
property oncommand
14111415
property oncontentvisibilityautostatechange
14121416
property oncontextlost
14131417
property oncontextmenu

‎third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1229,6 +1229,11 @@ interface CloseWatcher : EventTarget
12291229
method requestClose
12301230
setter oncancel
12311231
setter onclose
1232+
interface CommandEvent : Event
1233+
attribute @@toStringTag
1234+
getter command
1235+
getter source
1236+
method constructor
12321237
interface Comment : CharacterData
12331238
attribute @@toStringTag
12341239
method constructor
@@ -1735,6 +1740,7 @@ interface Document : Node
17351740
getter onchange
17361741
getter onclick
17371742
getter onclose
1743+
getter oncommand
17381744
getter oncontentvisibilityautostatechange
17391745
getter oncontextlost
17401746
getter oncontextmenu
@@ -1955,6 +1961,7 @@ interface Document : Node
19551961
setter onchange
19561962
setter onclick
19571963
setter onclose
1964+
setter oncommand
19581965
setter oncontentvisibilityautostatechange
19591966
setter oncontextlost
19601967
setter oncontextmenu
@@ -3351,6 +3358,8 @@ interface HTMLBodyElement : HTMLElement
33513358
setter vLink
33523359
interface HTMLButtonElement : HTMLElement
33533360
attribute @@toStringTag
3361+
getter command
3362+
getter commandForElement
33543363
getter disabled
33553364
getter form
33563365
getter formAction
@@ -3371,6 +3380,8 @@ interface HTMLButtonElement : HTMLElement
33713380
method constructor
33723381
method reportValidity
33733382
method setCustomValidity
3383+
setter command
3384+
setter commandForElement
33743385
setter disabled
33753386
setter formAction
33763387
setter formEnctype
@@ -3488,6 +3499,7 @@ interface HTMLElement : Element
34883499
getter onchange
34893500
getter onclick
34903501
getter onclose
3502+
getter oncommand
34913503
getter oncontentvisibilityautostatechange
34923504
getter oncontextlost
34933505
getter oncontextmenu
@@ -3623,6 +3635,7 @@ interface HTMLElement : Element
36233635
setter onchange
36243636
setter onclick
36253637
setter onclose
3638+
setter oncommand
36263639
setter oncontentvisibilityautostatechange
36273640
setter oncontextlost
36283641
setter oncontextmenu
@@ -5412,6 +5425,7 @@ interface MathMLElement : Element
54125425
getter onchange
54135426
getter onclick
54145427
getter onclose
5428+
getter oncommand
54155429
getter oncontentvisibilityautostatechange
54165430
getter oncontextlost
54175431
getter oncontextmenu
@@ -5523,6 +5537,7 @@ interface MathMLElement : Element
55235537
setter onchange
55245538
setter onclick
55255539
setter onclose
5540+
setter oncommand
55265541
setter oncontentvisibilityautostatechange
55275542
setter oncontextlost
55285543
setter oncontextmenu
@@ -7615,6 +7630,7 @@ interface SVGElement : Element
76157630
getter onchange
76167631
getter onclick
76177632
getter onclose
7633+
getter oncommand
76187634
getter oncontentvisibilityautostatechange
76197635
getter oncontextlost
76207636
getter oncontextmenu
@@ -7728,6 +7744,7 @@ interface SVGElement : Element
77287744
setter onchange
77297745
setter onclick
77307746
setter onclose
7747+
setter oncommand
77317748
setter oncontentvisibilityautostatechange
77327749
setter oncontextlost
77337750
setter oncontextmenu
@@ -11930,6 +11947,7 @@ namespace console
1193011947
getter onchange
1193111948
getter onclick
1193211949
getter onclose
11950+
getter oncommand
1193311951
getter oncontentvisibilityautostatechange
1193411952
getter oncontextlost
1193511953
getter oncontextmenu
@@ -12150,6 +12168,7 @@ namespace console
1215012168
setter onchange
1215112169
setter onclick
1215212170
setter onclose
12171+
setter oncommand
1215312172
setter oncontentvisibilityautostatechange
1215412173
setter oncontextlost
1215512174
setter oncontextmenu

0 commit comments

Comments
 (0)