-
Notifications
You must be signed in to change notification settings - Fork 518
usage metrics: report acquisition + parsers metrics to LAPI #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/area agent |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3709 +/- ##
==========================================
+ Coverage 60.67% 60.74% +0.06%
==========================================
Files 373 388 +15
Lines 41166 41345 +179
==========================================
+ Hits 24978 25115 +137
- Misses 14133 14172 +39
- Partials 2055 2058 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -102,7 +103,7 @@ func getParserMetric(url string, itemName string) (map[string]map[string]int, er | |||
ival := int(fval) | |||
|
|||
switch fam.Name { | |||
case "cs_reader_hits_total": | |||
case "cs_reader_hits_total": // What is this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it should be cs_parser_hits_total
ce6a61d#diff-413e4f0de6c52facefad2e23aeb8551601b31cb2521c744890c00b1f7d7ea954L183
Send more detailed metrics about acquisition and parsing to LAPI/CAPI to help users troubleshoot.
cscli metrics
in LAPI