[ability draft] Negative percentages are sorted incorrectly #55
Description
Issue
Negative percentages are sorted incorrectly in various table views on windrun.io.
Impacted Pages:
| Page | Screenshot |
|---|---|
| windrun.io/abilities (value column) |  |
| windrun.io/ability-high-skill (delta-win% column) |  |
| windrun.io/ability-pairs (synergy-delta column) |  |
| windrun.io/heroes/<hero-id> (value column) |  |
The buggy function appears to be present on all table pages, but not all have a column with negative percentage values.
Cause
The percSorter function is incorrectly parsing negative percentages. The culprit is the replace("-", "0.0"), which is mangling negative percentages. For example, "-10.1%" will be incorrectly converted to "0.010.1", which parseFloat evaluates as 0.01.