Skip to content

promote main #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 185 commits into
base: main
Choose a base branch
from
Draft

promote main #963

wants to merge 185 commits into from

Conversation

hubsmoke
Copy link
Member

@hubsmoke hubsmoke commented May 30, 2025 •
edited by kadamidev
Loading

Warning We have to backfill legacyDpids as soon as we merge this
promote main

shadrach-tayo and others added 30 commits May 12, 2025 21:49
@shadrach-tayo
create schema for journal features
cbd6005
@shadrach-tayo
add api spec
74e1309
@kadamidev
more specific icon field
d084c16
@kadamidev
rename generic table names/fields to more specific ones to not confla…
45b1dae 
…te existing db
@kadamidev
minimize the schema for now, uncertain on implementation details for …
7684353 
…some of the fields/tables
@kadamidev
few more schema modifications, initialize base journals schema
290cffd
@kadamidev
add journal role perm middleware
a4ce1cf
@kadamidev
update AuthenticatedRequests imports to use core type
ae17c5b
@kadamidev
api resp structure added
352806d
@kadamidev
add journal permissions matrix
dfadcc7
@kadamidev
journal schema mutations, make accepted optional, add timestamp for d…
907664d 
…ecisionAt
@kadamidev
base journalInviteService
e7356bc
@kadamidev
add journal relationship to event log
d3cc353
@kadamidev
add journal event log service
f5862b9
@kadamidev
add event logs for editor invites
94b43c2
@kadamidev
add invite editor controller/route
42bf9a8
@shadrach-tayo
update api pagination metadata and documentation
aa85a31
@shadrach-tayo
Merge pull request #955 from desci-labs/openalex-paging
98b9626 
Update api pagination metadata and documentation
@hubsmoke
send emails with correct biz entity and year
fa969fd
@hubsmoke
Merge branch 'develop' of https://github.com/desci-labs/nodes into de…
18d07a8 
…velop
@kadamidev
updated schema events
9160d5b
@kadamidev
editor invite decision controller
0712036
@kadamidev
journal invite/management routes
5ed7141
@kadamidev
add journal managment services, CRUD
bd54760
@kadamidev
create, update, journal controllers
96d6e8d
@shadrach-tayo
optimize api and add caching to repetitive calls
a1e6f5b
@shadrach-tayo
fix cache miss bug and refactor
d9ddce0
@shadrach-tayo
Merge pull request #956 from desci-labs/optimize-submissions-api
b7dde06 
Optimize get submissions api
@kadamidev
neverthrow result pattern refactor
4256f70
@kadamidev
remove editor, update role controllers
4fdb708
cursor[bot]
cursor bot reviewed Jun 9, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Error Handling in `assignSubmissionToEditor`

The assignSubmissionToEditor function uses generic Error for conditions that should use specific API error classes like ForbiddenError or NotFoundError. This is inconsistent with the error handling pattern established by other functions in the same file.

desci-server/src/services/journals/JournalSubmissionService.ts#L174-L175

nodes/desci-server/src/services/journals/JournalSubmissionService.ts

Lines 174 to 175 in 916139f

if (!chiefEditor) {
throw new Error('Only Chief editor is allowed to assign submissions');

desci-server/src/services/journals/JournalSubmissionService.ts#L186-L187

nodes/desci-server/src/services/journals/JournalSubmissionService.ts

Lines 186 to 187 in 916139f

if (submission.status !== SubmissionStatus.SUBMITTED) {
throw new Error('Submission is not in the submitted state');

Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

kadamidev and others added 20 commits June 10, 2025 20:59
@kadamidev
remove oa workId prefix
fa59051
@kadamidev
Merge pull request #1007 from desci-labs/oa-db-prefix
6b3f467 
Remove OA prefix for OA data db switch
@shadrach-tayo
feat: publish metrics api implementation and documentation
847e445
@shadrach-tayo
implement research object metric api and documentation
3cdce17
@kadamidev
reduce ambiguity for editorId routes, favor editorUserId to prevent bugs
6891f2e
@kadamidev
update tests
1a6de27
@kadamidev
update remove controller, param change
79de86b
@kadamidev
Merge pull request #1008 from desci-labs/journal-api-adjustments
679c38a 
Journal API adjustments
@shadrach-tayo
feat: KPI metrics api and services implementation
939ff50
@shadrach-tayo
api documentation
f4b7e0f
@shadrach-tayo
refactor
90f9e3c
@shadrach-tayo
log validation failed trace
d59da26
@shadrach-tayo
Merge pull request #1009 from desci-labs/tay/kpi-apis
33914c3 
Tay/kpi apis
@shadrach-tayo
api integration tests for user engagement and publish metrics
8e66652
@shadrach-tayo
fix: remove duplicate schema field
371344a
@shadrach-tayo
Merge pull request #1011 from desci-labs/fix/submission-schema
be769d3 
fix: remove duplicate schema field
@shadrach-tayo
api integration tests for feature adoption, retention and research ob…
0ea2911 
…ject metrics
@shadrach-tayo
chore: refactor test file
de7ca08
@m0ar
Merge pull request #998 from desci-labs/m0ar/ceramic-one-nodes
72d1afc 
Misc C1 node fixes
@shadrach-tayo
Merge pull request #1012 from desci-labs/kpi-tests
822bbb0 
Integration tests for KPI Metrics API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hubsmoke @shadrach-tayo @kadamidev @m0ar