Skip to content

plugins.kick: fix 403 error and VOD URL matcher #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

plugins.kick: fix 403 error and VOD URL matcher #6384

merged 1 commit into from
Jan 6, 2025

Conversation

bastimeyer
Copy link
Member

Closes #6325

See #6325 (comment) (credits to @Hakkin)

This seems to fix the 403 response just fine, so let's add the header to the entire HTTP session when initializing the plugin. Alternatively, the header could be added by the custom KickAdapter, but then the adapter would also need to be mounted on other (sub-)domains where the HLS stream data is accessed from. Or it could be set on all API requests and HLSStream instances, but that would be a bit redundant and therefore unnecessary.

In addition to fixing the 403 responses, this PR also fixes the VOD URL matcher. Surprisingly though, some VODs I checked still returned 403 when accessing the HLS playlist, which made me believe that the header didn't work. Turns out that those VODs are not accessible on their site either.

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jan 6, 2025
@bastimeyer
Copy link
Member Author 

$ streamlink --hls-duration=10 -o /dev/null https://kick.com/zmok best
[cli][info] Found matching plugin kick for URL https://kick.com/zmok
[cli][info] Available streams: 160p (worst), 360p, 480p, 720p60, 1080p60 (best)
[cli][info] Opening stream: 1080p60 (hls)
[cli][info] Writing output to
/dev/null
[stream.hls][info] Stopping stream early after 10
[download] Written 7.67 MiB to /dev/null (5s @ 1.39 MiB/s)                                                                                      
[cli][info] Stream ended
[cli][info] Closing currently open stream...

$ streamlink --hls-duration=10 -o /dev/null https://kick.com/kukudota2/videos/4acba712-a1cd-45b0-8ce0-4b534d4c271f best
[cli][info] Found matching plugin kick for URL https://kick.com/kukudota2/videos/4acba712-a1cd-45b0-8ce0-4b534d4c271f
[cli][info] Available streams: 160p (worst), 360p, 480p, 720p60, 1080p60 (best)
[cli][info] Opening stream: 1080p60 (hls)
[cli][info] Writing output to
/dev/null
[stream.hls][info] Stopping stream early after 10
[download] Written 9.48 MiB to /dev/null (0s)                                                                                                   
[cli][info] Stream ended
[cli][info] Closing currently open stream...

$ streamlink --hls-duration=10 -o /dev/null https://kick.com/admiralbulldog?clip=clip_01HSNHF69RPPR9JX0VQ6WM2YVC best
[cli][info] Found matching plugin kick for URL https://kick.com/admiralbulldog?clip=clip_01HSNHF69RPPR9JX0VQ6WM2YVC
[cli][info] Available streams: clip (worst, best)
[cli][info] Opening stream: clip (hls)
[cli][info] Writing output to
/dev/null
[stream.hls][info] Stopping stream early after 10
[download] Written 8.21 MiB to /dev/null (5s @ 1.52 MiB/s)                                                                                      
[cli][info] Stream ended
[cli][info] Closing currently open stream...

@bastimeyer bastimeyer merged commit 0c95364 into streamlink:master Jan 6, 2025
23 checks passed
@bastimeyer bastimeyer deleted the plugins/kick/fix-403-and-vod-matcher branch January 6, 2025 18:02
@bastimeyer bastimeyer mentioned this pull request Jan 6, 2025
Closed
@SparklingTopaz
Copy link

SparklingTopaz commented Jan 11, 2025 •
edited
Loading

At least for me adding -http-header "Sec-Fetch-User=?1" does not help.
I'm still getting the 403 Client Error.

@bastimeyer
Copy link
Member Author

The plugin appears to be working fine. Make sure that you're using the latest version. Without a full debug log, any claims about non-working plugins or bugs are meaningless. If there is indeed a plugin issue, then please open a new plugin issue thread and fill in all the required details.

@streamlink streamlink locked and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastimeyer @SparklingTopaz