🚀 GitHub Actions update, use commit from PR, not pre-merge (fastapi#1761)

tiangolo · web-flow · commit 8bafe2a48269 · 2020-07-21T23:08:14.000+02:00
* &#128293; Remove deploy badge that won't show correctly until next release

after the fixes to the Gitter bot

* &#128027; Fix GitHub Action to upload docs artifacts with commit from PR, not pre-merge

* &#9851;&#65039; Run zip docs and artifact upload only on PRs
diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml
@@ -19,10 +19,12 @@ jobs:
       - name: Build Docs
         run: python3.7 ./scripts/docs.py build-all
       - name: Zip docs
+        if: github.event_name == 'pull_request'
         run: bash ./scripts/zip-docs.sh
       - uses: actions/upload-artifact@v2
+        if: github.event_name == 'pull_request'
         with:
-          name: docs-zip-${{ github.sha }}
+          name: docs-zip-${{ github.event.pull_request.head.sha }}
           path: ./docs.zip
       - name: Deploy to Netlify
         uses: nwtgck/actions-netlify@v1.1.5
diff --git a/README.md b/README.md
@@ -8,9 +8,6 @@
 <a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3ATest" target="_blank">
     <img src="https://github.com/tiangolo/fastapi/workflows/Test/badge.svg" alt="Test">
 </a>
-<a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3APublish" target="_blank">
-    <img src="https://github.com/tiangolo/fastapi/workflows/Publish/badge.svg" alt="Publish">
-</a>
 <a href="https://codecov.io/gh/tiangolo/fastapi" target="_blank">
     <img src="https://img.shields.io/codecov/c/github/tiangolo/fastapi?color=%2334D058" alt="Coverage">
 </a>
diff --git a/docs/en/docs/index.md b/docs/en/docs/index.md
@@ -8,9 +8,6 @@
 <a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3ATest" target="_blank">
     <img src="https://github.com/tiangolo/fastapi/workflows/Test/badge.svg" alt="Test">
 </a>
-<a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3APublish" target="_blank">
-    <img src="https://github.com/tiangolo/fastapi/workflows/Publish/badge.svg" alt="Publish">
-</a>
 <a href="https://codecov.io/gh/tiangolo/fastapi" target="_blank">
     <img src="https://img.shields.io/codecov/c/github/tiangolo/fastapi?color=%2334D058" alt="Coverage">
 </a>
diff --git a/docs/es/docs/index.md b/docs/es/docs/index.md
@@ -8,9 +8,6 @@
 <a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3ATest" target="_blank">
     <img src="https://github.com/tiangolo/fastapi/workflows/Test/badge.svg" alt="Test">
 </a>
-<a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3APublish" target="_blank">
-    <img src="https://github.com/tiangolo/fastapi/workflows/Publish/badge.svg" alt="Publish">
-</a>
 <a href="https://codecov.io/gh/tiangolo/fastapi" target="_blank">
     <img src="https://img.shields.io/codecov/c/github/tiangolo/fastapi?color=%2334D058" alt="Coverage">
 </a>
diff --git a/docs/pt/docs/index.md b/docs/pt/docs/index.md
@@ -8,9 +8,6 @@
 <a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3ATest" target="_blank">
     <img src="https://github.com/tiangolo/fastapi/workflows/Test/badge.svg" alt="Test">
 </a>
-<a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3APublish" target="_blank">
-    <img src="https://github.com/tiangolo/fastapi/workflows/Publish/badge.svg" alt="Publish">
-</a>
 <a href="https://codecov.io/gh/tiangolo/fastapi" target="_blank">
     <img src="https://img.shields.io/codecov/c/github/tiangolo/fastapi?color=%2334D058" alt="Coverage">
 </a>
diff --git a/docs/zh/docs/index.md b/docs/zh/docs/index.md
@@ -8,9 +8,6 @@
 <a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3ATest" target="_blank">
     <img src="https://github.com/tiangolo/fastapi/workflows/Test/badge.svg" alt="Test">
 </a>
-<a href="https://github.com/tiangolo/fastapi/actions?query=workflow%3APublish" target="_blank">
-    <img src="https://github.com/tiangolo/fastapi/workflows/Publish/badge.svg" alt="Publish">
-</a>
 <a href="https://codecov.io/gh/tiangolo/fastapi" target="_blank">
     <img src="https://img.shields.io/codecov/c/github/tiangolo/fastapi?color=%2334D058" alt="Coverage">
 </a>
