Skip to content

Commit eb187d1

Browse files
stephentoubstephentoub
authored
Rewrite Socket.ConnectAsync for DNS with async/await (#43661)
* Avoid several WildcardBindForConnectIfNecessary allocations on each connect * Rewrite Socket.ConnectAsync for DNS with async/await Rips out all of the APM code that was previously used to implement this and replaces it with {Value}Task-based async/await implementations.
1 parent 9b3575d commit eb187d1

15 files changed

+335
-1393
lines changed

‎src/libraries/System.Net.Sockets/src/System.Net.Sockets.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@
4545
<Compile Include="System\Net\Sockets\UdpReceiveResult.cs" />
4646
<Compile Include="System\Net\Sockets\AcceptOverlappedAsyncResult.cs" />
4747
<Compile Include="System\Net\Sockets\BaseOverlappedAsyncResult.cs" />
48-
<Compile Include="System\Net\Sockets\ConnectOverlappedAsyncResult.cs" />
4948
<Compile Include="System\Net\Sockets\DisconnectOverlappedAsyncResult.cs" />
50-
<Compile Include="System\Net\Sockets\MultipleConnectAsync.cs" />
5149
<Compile Include="System\Net\Sockets\OverlappedAsyncResult.cs" />
5250
<Compile Include="System\Net\Sockets\ReceiveMessageOverlappedAsyncResult.cs" />
5351
<Compile Include="System\Net\Sockets\UnixDomainSocketEndPoint.cs" />
@@ -100,7 +98,6 @@
10098
<!-- Windows: CoreCLR -->
10199
<Compile Include="System\Net\Sockets\AcceptOverlappedAsyncResult.Windows.cs" />
102100
<Compile Include="System\Net\Sockets\BaseOverlappedAsyncResult.Windows.cs" />
103-
<Compile Include="System\Net\Sockets\ConnectOverlappedAsyncResult.Windows.cs" />
104101
<Compile Include="System\Net\Sockets\OverlappedAsyncResult.Windows.cs" />
105102
<Compile Include="System\Net\Sockets\DynamicWinsockMethods.cs" />
106103
<Compile Include="System\Net\Sockets\ReceiveMessageOverlappedAsyncResult.Windows.cs" />
@@ -198,7 +195,6 @@
198195
<ItemGroup Condition="'$(TargetsUnix)' == 'true'">
199196
<Compile Include="System\Net\Sockets\AcceptOverlappedAsyncResult.Unix.cs" />
200197
<Compile Include="System\Net\Sockets\BaseOverlappedAsyncResult.Unix.cs" />
201-
<Compile Include="System\Net\Sockets\ConnectOverlappedAsyncResult.Unix.cs" />
202198
<Compile Include="System\Net\Sockets\DisconnectOverlappedAsyncResult.Unix.cs" />
203199
<Compile Include="System\Net\Sockets\OverlappedAsyncResult.Unix.cs" />
204200
<Compile Include="System\Net\Sockets\ReceiveMessageOverlappedAsyncResult.Unix.cs" />

‎src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.Unix.cs

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.Windows.cs

Lines changed: 0 additions & 48 deletions
This file was deleted.

‎src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.cs

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)