Skip to content

add a small test framework to enforce port 0 use #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented May 27, 2025

Based on #1939 and #1966

Copy link

PR missing one of the required labels: {'bug', 'new feature', 'dependencies', 'breaking-change', 'enhancement', 'documentation', 'internal'}

@wyfo wyfo added the internal Changes not included in the changelog label May 27, 2025
wyfo added 5 commits May 27, 2025 09:02
When binding on port 0, the OS assigns the actual port. However,
the multicast locator was stored without taking this potential port
change.
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (c051173) to head (5c8f13b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   70.91%   70.87%   -0.05%     
==========================================
  Files         364      364              
  Lines       61491    61517      +26     
==========================================
- Hits        43609    43599      -10     
- Misses      17882    17918      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant