Automating TC-LWM-2.1 (step 7) and updating pics #39972
Open
+81
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates a manual test step for the Laundry Washer Mode cluster and updates the PICS values for the CI environment. The automation of the test step is a welcome improvement, and the implementation correctly validates a comprehensive set of failure status codes. The change to the ci-pics-values file to disable this test in CI is also appropriate, given that the underlying functionality is not yet supported in the SDK sample app.
|
PR #39972: Size comparison from 7dc2506 to 9b57160 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 14, 2025
| @@ -759,7 +759,7 @@ LWM.S.C01.Tx=1 | |||
| PIXIT.LWM.MODE_CHANGE_FAIL=1 | |||
| PIXIT.LWM.MODE_CHANGE_OK=1 | |||
|
|
|||
| LWM.S.M.CAN_TEST_MODE_FAILURE=1 | |||
| LWM.S.M.CAN_TEST_MODE_FAILURE=0 | |||
There was a problem hiding this comment.
if we turn off this in CI, how can we ensure that the test works?
I am conflicted here: on one hand an automated test is better than manual, however on the other side I wonder if this will bitrot. Are there any plans/issues to support this in sample apps? Or would we just accept that if devices fail they will turn off the PICS (I find that likely as it is easier to change an enabling and get certified instead of trying to fix things that the SDK does not test to be correctly implemented in CI)
|
@r-recchia the |
juandediosg
reviewed
Jul 15, 2025
There was a problem hiding this comment.
Suggest adding a note to Step 7 in the test plan (/allclusters.html#_tc_lwm_2_1_change_to_mode_functionality_with_dut_as_server): This step is only executed if the PICS value LWM.S.M.CAN_TEST_MODE_FAILURE is set to 1. If the PICS is set to 0, this step is skipped during test execution.
Please confirm this approach with @cecille
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #622
Updates
It automates test step 7. The SDK does not implement this command so the PICS value LWM.S.M.CAN_TEST_MODE_FAILURE was updated to 0 in order to skip the test step. Also updated constraint values.
Testing
In the first terminal:
rm /tmp/chip_*In the second terminal: