rename to extra_bindings per IRC discussion.

emilio · emilio · commit 5f8e02729023 · 2019-06-25T21:33:19.000+02:00
diff --git a/docs.md b/docs.md
@@ -752,10 +752,10 @@ exclude = ["libc"]
 clean = false
 
 # Which crates other than the top-level binding crate we should generate
-# top-level constants / globals and functions.
+# bindings for.
 #
 # default: []
-deps_with_top_level_items = ["my_awesome_dep"]
+extra_bindings = ["my_awesome_dep"]
 
 [parse.expand]
 # A list of crate names that should be run through `cargo expand` before
diff --git a/src/bindgen/config.rs b/src/bindgen/config.rs
@@ -564,7 +564,7 @@ pub struct ParseConfig {
     pub clean: bool,
     /// List of crate names which generate consts, statics, and fns. By default
     /// no dependent crates generate them.
-    pub deps_with_top_level_items: Vec<String>,
+    pub extra_bindings: Vec<String>,
 }
 
 impl ParseConfig {
@@ -578,9 +578,7 @@ impl ParseConfig {
             return true;
         }
 
-        self.deps_with_top_level_items
-            .iter()
-            .any(|dep| dep == crate_name)
+        self.extra_bindings.iter().any(|dep| dep == crate_name)
     }
 }
 
diff --git a/template.toml b/template.toml
@@ -127,7 +127,7 @@ parse_deps = false
 # include = []
 exclude = []
 clean = false
-# deps_with_top_level_items = []
+extra_bindings = []
 
 
 
diff --git a/tests/rust/workspace/cbindgen.toml b/tests/rust/workspace/cbindgen.toml
@@ -1,3 +1,3 @@
 [parse]
 parse_deps = true
-deps_with_top_level_items = ["dep"]
+extra_bindings = ["dep"]

Original file line number	Diff line number	Diff line change
`@@ -564,7 +564,7 @@ pub struct ParseConfig {`
`564`	`564`	`pub clean: bool,`
`565`	`565`	`/// List of crate names which generate consts, statics, and fns. By default`
`566`	`566`	`/// no dependent crates generate them.`
`567`		`- pub deps_with_top_level_items: Vec<String>,`
	`567`	`+ pub extra_bindings: Vec<String>,`
`568`	`568`	`}`
`569`	`569`
`570`	`570`	`impl ParseConfig {`
`@@ -578,9 +578,7 @@ impl ParseConfig {`
`578`	`578`	`return true;`
`579`	`579`	`}`
`580`	`580`
`581`		`- self.deps_with_top_level_items`
`582`		`- .iter()`
`583`		`- .any(\|dep\| dep == crate_name)`
	`581`	`+ self.extra_bindings.iter().any(\|dep\| dep == crate_name)`
`584`	`582`	`}`
`585`	`583`	`}`
`586`	`584`