feat: support TypeScript syntax in no-invalid-this rule (#19532)

Tanujkanti4441 · web-flow · commit db650a036baf · 2025-04-09T11:41:26.000+05:30
diff --git a/docs/src/rules/no-invalid-this.md b/docs/src/rules/no-invalid-this.md
@@ -284,6 +284,59 @@ obj.Foo = function Foo() {
 
 :::
 
+This rule additionally supports TypeScript type syntax.
+
+Examples of **incorrect** TypeScript code for this rule:
+
+:::incorrect
+
+```ts
+/*eslint no-invalid-this: "error"*/
+
+function foo(bar: string) {
+    this.prop;
+    console.log(bar)
+}
+
+/** @this Obj */
+foo(function() {
+    console.log(this);
+    z(x => console.log(x, this));
+});
+
+function foo() {
+  class C {
+    accessor [this.a] = foo;
+  }
+}
+```
+
+:::
+
+Examples of **correct** TypeScript code for this rule:
+
+:::correct
+
+```ts
+/*eslint no-invalid-this: "error"*/
+
+interface SomeType {
+    prop: string;
+}
+
+function foo(this: SomeType) {
+    this.prop;
+}
+
+class A {
+    a = 5;
+    b = this.a;
+    accessor c = this.a;
+}
+```
+
+:::
+
 ## When Not To Use It
 
 If you don't want to be notified about usage of `this` keyword outside of classes or class-like objects, you can safely disable this rule.
diff --git a/lib/rules/no-invalid-this.js b/lib/rules/no-invalid-this.js
@@ -36,6 +36,8 @@ function isCodePathWithLexicalThis(codePath, node) {
 /** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
+		dialects: ["javascript", "typescript"],
+		language: "javascript",
 		type: "suggestion",
 
 		defaultOptions: [{ capIsConstructor: true }],
@@ -140,8 +142,28 @@ module.exports = {
 				stack.pop();
 			},
 
+			"AccessorProperty > *.value"(node) {
+				stack.push({
+					init: true,
+					node,
+					valid: true,
+				});
+			},
+
+			"AccessorProperty:exit"() {
+				stack.pop();
+			},
+
 			// Reports if `this` of the current context is invalid.
 			ThisExpression(node) {
+				// Special case: skip `this` if it's the value of an AccessorProperty
+				if (
+					node.parent.type === "AccessorProperty" &&
+					node.parent.value === node
+				) {
+					return;
+				}
+
 				const current = stack.getCurrent();
 
 				if (current && !current.valid) {
diff --git a/lib/rules/utils/ast-utils.js b/lib/rules/utils/ast-utils.js
@@ -1488,6 +1488,17 @@ module.exports = {
 			return false;
 		}
 
+		// Check if the function has a parameter named `this`.
+		if (
+			(node.type === "FunctionDeclaration" ||
+				node.type === "FunctionExpression") &&
+			node.params.some(
+				param => param.type === "Identifier" && param.name === "this",
+			)
+		) {
+			return false;
+		}
+
 		if (
 			(capIsConstructor && isES5Constructor(node)) ||
 			hasJSDocThisTag(node, sourceCode)
diff --git a/tests/lib/rules/no-invalid-this.js b/tests/lib/rules/no-invalid-this.js
