Skip to content

Feature/#732/rebuid yargs structure clean branch #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

vitran96
Copy link

@vitran96 vitran96 commented May 4, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #732

image
image
image
image
image

What is the new behavior?

image
image
image
image
image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

vitran96 added 2 commits May 4, 2025 07:44
commit 6650f94
Author: vitran96 <tranuytrieuvi@gmail.com>
Date:   Sun May 4 07:39:21 2025 +0700

    evershopcommerce#732 - feat - pass skip-minify flag to build function

commit c9d5025
Author: vitran96 <tranuytrieuvi@gmail.com>
Date:   Sat May 3 23:46:53 2025 +0700

    evershopcommerce#732 - feat - pass isDebug flag to start server function

commit 8370870
Author: vitran96 <tranuytrieuvi@gmail.com>
Date:   Sat May 3 22:25:24 2025 +0700

    evershopcommerce#732 - refactor - clean up comment

commit dd9ae09
Author: vitran96 <tranuytrieuvi@gmail.com>
Date:   Sat May 3 11:19:02 2025 +0700

    evershopcommerce#732 - refactor - move majority of command to cli entry script

commit f3110cf
Author: vitran96 <tranuytrieuvi@gmail.com>
Date:   Sat May 3 07:09:11 2025 +0700

    evershopcommerce#732 - refactor - define command and option at evershop entrypoint to render proper help

commit 930a967
Author: vitran96 <tranuytrieuvi@gmail.com>
Date:   Sun Apr 20 16:12:54 2025 +0700

    evershopcommerce#732 - feat - add help commands
@vitran96 vitran96 marked this pull request as ready for review May 4, 2025 01:29
@vitran96
Copy link
Author

Hi @treoden
It seems that PR has been approved. How can we proceed? Will you merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants